-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Closed
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Description
Using go1.13rc1
After #16860 was closed, I was hoping that I could build byte-for-byte identical builds regardless of what machine was used to build the binaries. At the present moment, building binaries are nearly identical regardless of the machine used, except for the following bytes:
$ diff <(hexdump -Cv linux1/protoc-gen-go.v1.19.0-devel.linux.amd64) <(hexdump -Cv linux2/protoc-gen-go.v1.19.0-devel.linux.amd64)
251,254c251,254
< 00000fa0 53 00 00 00 04 00 00 00 47 6f 00 00 76 72 6e 46 |S.......Go..vrnF|
< 00000fb0 43 55 48 32 42 74 57 4e 53 4c 6a 62 54 78 47 35 |CUH2BtWNSLjbTxG5|
< 00000fc0 2f 54 49 30 2d 6d 6e 55 4f 45 49 52 5f 41 48 6c |/TI0-mnUOEIR_AHl|
< 00000fd0 36 57 39 66 65 2f 6b 62 30 43 44 67 66 72 38 64 |6W9fe/kb0CDgfr8d|
---
> 00000fa0 53 00 00 00 04 00 00 00 47 6f 00 00 61 69 6a 4b |S.......Go..aijK|
> 00000fb0 48 6b 71 33 2d 41 36 37 64 6a 63 77 50 4b 48 79 |Hkq3-A67djcwPKHy|
> 00000fc0 2f 65 66 2d 78 37 5f 34 72 4c 4d 5f 73 68 36 73 |/ef-x7_4rLM_sh6s|
> 00000fd0 79 56 75 47 31 2f 6b 62 30 43 44 67 66 72 38 64 |yVuG1/kb0CDgfr8d|
There seems to be some type of build ID encoded into the binary.
Steps to reproduce:
$ git clone https://go.googlesource.com/protobuf
$ cd protobuf
$ git checkout 08ff73004835d46c133844f593fe74596d3e8194
$ go test -mod=vendor -timeout=60m -count=1 integration_test.go -buildRelease
$ md5sum bin/protoc-gen-go.v1.19.0-devel.linux.amd64
Unfortunately, that command will take a while to run since it needs to build the C++ protoc
binary as a dependency.
This need not block go1.13
release.
meeDamian, dmitshur and Equim-chan
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.