x/tools/gopls: redundant import name added

[muirdm]

Steps to reproduce:

Starting with:

package main

import "os/exec"

func main() {
	exec.CommandContext()
}

1. Complete at CommandContext(<>) and select "context.Background"
2. I expect to get an import for "context", but I get context "context" (redundant alias).

Also note that it says from "context" in the candidate description although it is not required in this case.

/cc @stamblerre @heschik

[gopherbot]

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

[gopherbot]

Change https://golang.org/cl/205657 mentions this issue: internal/lsp/source: don't unconditionally name imports

[heschi]

Silly mistake, thanks for the report. Why do you say that from "context" isn't necessary? It's adding a new import and I think the user should know what it is. They could have multiple context packages, or be missing the one they actually want.

[muirdm]

Why do you say that from "context" isn't necessary?

In this case I happen to know that I'm getting completions from the package of the function parameter (i.e. "context"), so there is only one possibility. But you bring up a good point that there is no existing import so the user normally can't/won't know where the candidates are coming from.

[heschi]

That would be true in some cases, but not this one. context.Context is an interface, so I was also getting completions from x/net/context, for example. I think it's probably healthy to show it unconditionally, FWIW.

[gopherbot]

Change https://golang.org/cl/205738 mentions this issue: internal/lsp/source: don't unconditionally name imports