Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer #35675

Open
dmitshur opened this issue Nov 18, 2019 · 1 comment
Open
Labels
help wanted NeedsInvestigation Tools
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 18, 2019

Go 1.13 is the last release that runs on Native Client (NaCl), as mentioned at https://golang.org/doc/go1.13#ports.

present has a flag and mode to use Native Client:

$ present -help
...
  -nacl
    	use Native Client environment playground (prevents non-Go code execution) when using local WebSocket transport
...

It won't work with Go 1.14 and newer, so we need to deal with that. First step is coming up with a plan.

@dmitshur dmitshur added help wanted NeedsInvestigation Tools labels Nov 18, 2019
@dmitshur dmitshur added this to the Go1.14 milestone Nov 18, 2019
@toothrot toothrot removed this from the Go1.14 milestone Feb 25, 2020
@toothrot toothrot added this to the Go1.15 milestone Feb 25, 2020
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 15, 2020

Moving milestone to backlog.

@ianlancetaylor ianlancetaylor removed this from the Go1.15 milestone Jun 15, 2020
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsInvestigation Tools
Projects
None yet
Development

No branches or pull requests

3 participants