Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer #35675

Open
dmitshur opened this issue Nov 18, 2019 · 1 comment
Open

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 18, 2019

Go 1.13 is the last release that runs on Native Client (NaCl), as mentioned at https://golang.org/doc/go1.13#ports.

present has a flag and mode to use Native Client:

$ present -help
...
  -nacl
    	use Native Client environment playground (prevents non-Go code execution) when using local WebSocket transport
...

It won't work with Go 1.14 and newer, so we need to deal with that. First step is coming up with a plan.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 15, 2020

Moving milestone to backlog.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.15, Backlog Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.