cmd/vet: -<analyzer> flags don't work when outside of GOROOT #35837
Comments
I have a local fix, would like to send it for reviewing if this is a bug. |
/cc @alandonovan @josharian @mvdan per owners. |
Thanks, this does indeed look like a bug. Please do share your fix.
|
Thanks for confirming. |
Change https://golang.org/cl/209498 mentions this issue: |
Change https://golang.org/cl/210937 mentions this issue: |
This fixes a regression introduced in CL 209498, found while investigating #32471. Also fix $WORK replacement in cmd/go/internal/work.(*Builder).Showcmd when b.WorkDir includes a backslash and appears in a quoted string. That fix is needed in order to write a precise test that passes under Windows, since Windows directories nearly always include backslashes. Updates #35837 Change-Id: I5fddc5435d5d283a3e598989209d873b59b0a39c Reviewed-on: https://go-review.googlesource.com/c/go/+/210937 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Jay Conrod <jayconrod@google.com>
Change https://golang.org/cl/217897 mentions this issue: |
…t flags is non-empty Updates #35837 Fixes #37030 Change-Id: Ifd3435803622a8624bab55a0f3fbc8855025282f Reviewed-on: https://go-review.googlesource.com/c/go/+/217897 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
-unreachable=false works even running 'go vet' outside <go root>/src
What did you see instead?
the unreachable warning is not suppressed.
The text was updated successfully, but these errors were encountered: