Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: list_constraints test broken #35976

Closed
jayconrod opened this issue Dec 4, 2019 · 1 comment
Closed

cmd/go: list_constraints test broken #35976

jayconrod opened this issue Dec 4, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Dec 4, 2019

The list_constraints test was introduced in CL 209660. It sets GOOS to darwin without setting GOARCH. The test is broken on builders for architectures that where darwin is not a valid GOOS.

Thanks to @cherrymui for calling this out.

@jayconrod jayconrod added the Soon label Dec 4, 2019
@jayconrod jayconrod added this to the Go1.14 milestone Dec 4, 2019
@jayconrod jayconrod self-assigned this Dec 4, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Dec 4, 2019

Change https://golang.org/cl/209900 mentions this issue: cmd/go: fix list_constraints test on non-amd64 platforms

@gopherbot gopherbot closed this in 709dbd2 Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.