Skip to content

x/build: get more coverage with the ssacheck builder #36756

@josharian

Description

@josharian

The ssacheck builder currently builds only amd64, and with a fixed random seed.

We should improve on both dimensions.

  • CL 216418 lets us provide a random seed. We could generate the random seed and print it to stdout before using it, so that any failure will be reproducible from the log.
  • We should either run on all architectures, or pick one at random each time from go tool dist list (and log it, for reproducibility).

I suspect that doing both of these things is pretty easy, and it'd get us extra test coverage, so it'd be nice to do soon. This would have caught both #36723 and #36755.

cc @cherrymui @randall77 @dmitshur @bradfitz

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions