Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: write Go 1.14 release notes #36878

Closed
dmitshur opened this issue Jan 29, 2020 · 47 comments
Closed

doc: write Go 1.14 release notes #36878

dmitshur opened this issue Jan 29, 2020 · 47 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 29, 2020

Tracking bug for writing the Go 1.14 Release Notes.

The latest state on tip can be viewed at https://tip.golang.org/doc/go1.14.

Previously #17929, #15810, #5929, etc.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 30, 2020

Change https://golang.org/cl/216997 mentions this issue: doc/go1.14: document overlapping interfaces change (update release notes)

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 30, 2020

Change https://golang.org/cl/217099 mentions this issue: doc: document new hash/maphash package

gopherbot pushed a commit that referenced this issue Jan 30, 2020
…tes)

Updates #6977.
Updates #36878.

Change-Id: I40594be85ee0a0d4b35bacc90104568d2b8a4761
Reviewed-on: https://go-review.googlesource.com/c/go/+/216997
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 30, 2020

Change https://golang.org/cl/217100 mentions this issue: doc/go1.14: fix minot typo (update release notes)

gopherbot pushed a commit that referenced this issue Jan 30, 2020
Follow-up on https://golang.org/cl/216200/2/doc/go1.14.html#423 .

Updates #36878.

Change-Id: I693a9eb05c6f1f42721a92fda46a4f3449defa24
Reviewed-on: https://go-review.googlesource.com/c/go/+/217100
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217122 mentions this issue: doc/go1.14: mime: .js files now text/javascript

gopherbot pushed a commit that referenced this issue Jan 31, 2020
Update #36878
Update #28322

Change-Id: I793c7c4dbdd23fdecd715500e90b7cc0cbe4cea5
Reviewed-on: https://go-review.googlesource.com/c/go/+/217099
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217067 mentions this issue: doc/go1.14: mention that debug/dwarf now supports DWARF 5

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217123 mentions this issue: doc/go1.14: mention new method encoding/json.Decoder.InputOffset

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217124 mentions this issue: doc/go1.14: mention new field go/build.Context.Dir

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217125 mentions this issue: doc/go1.14: mention go/doc.NewFromFiles and associated new data fields

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217126 mentions this issue: doc/go1.14: mention new log.Lmsgprefix flag

gopherbot pushed a commit that referenced this issue Jan 31, 2020
Updates #23864
Updates #36878

Change-Id: I6efdaafbe5207c625643f201a5931ad735941365
Reviewed-on: https://go-review.googlesource.com/c/go/+/217125
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217127 mentions this issue: doc/go1.14: mention new math/bits functions Rem, Rem32, Rem64

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217128 mentions this issue: doc/go1.14: mention new method mime/multipart.(*Reader).NextRawPart

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217129 mentions this issue: doc/go1.14: mention net/http.Header.Values, net/textproto.MIMEHeader.Values

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217130 mentions this issue: doc/go1.14: mention new field Transport.DialTLSContext

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217131 mentions this issue: doc/go1.14: mention new field net/http/httptest/Server.EnableHTTP2

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217132 mentions this issue: doc/go1.14: mention new method strconv.NumError.Unwrap

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217133 mentions this issue: doc/go1.14: mention update to Unicode 12

gopherbot pushed a commit that referenced this issue Jan 31, 2020
Updates #34939
Updates #36878

Change-Id: Ifa9a17b5b16bfcfbfe1d113a2b66a63ea3a6b59c
Reviewed-on: https://go-review.googlesource.com/c/go/+/217131
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit that referenced this issue Jan 31, 2020
…Values

These methods are new in Go 1.14.

Updates #34799
Updates #36878

Change-Id: I063f5cb4638d7e0716e6ce2a8c3fffced51bbd34
Reviewed-on: https://go-review.googlesource.com/c/go/+/217129
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit that referenced this issue Jan 31, 2020
Updates #21526
Updates #36878

Change-Id: Ic3ae18d31eddb9df01241cbddcc3b7b750cfaa44
Reviewed-on: https://go-review.googlesource.com/c/go/+/217130
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit that referenced this issue Jan 31, 2020
Updates #36878

Change-Id: Ia8441de8a04fead1f76c72f662bcb877e2265c3e
Reviewed-on: https://go-review.googlesource.com/c/go/+/217133
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit that referenced this issue Jan 31, 2020
Updates #29090
Updates #36878

Change-Id: I63f0eb583285d5c12f591cb704097cdf6a67b64f
Reviewed-on: https://go-review.googlesource.com/c/go/+/217128
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@c-yan

This comment has been minimized.

Copy link

@c-yan c-yan commented Feb 5, 2020

@dmitshur I confirmed that it was restored. Thank you.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 7, 2020

Change https://golang.org/cl/218297 mentions this issue: hash/maphash: mention that hash values do not persist in package docs

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 8, 2020

Change https://golang.org/cl/218637 mentions this issue: doc/go1.14: add link to TempFile in io/ioutil

gopherbot pushed a commit that referenced this issue Feb 8, 2020
Unlike the others, the dt tag of reflect is not next to the dl tag.
The dd's closing tags may or may not have been omitted. They were unified without omission.

Updates #36878

Change-Id: I4e24f93fe8763ae8a1e4392db72e0b4818884f44
Reviewed-on: https://go-review.googlesource.com/c/go/+/217701
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 8, 2020

Change https://golang.org/cl/218638 mentions this issue: doc/go1.14: rearrange in alphabetical order

gopherbot pushed a commit that referenced this issue Feb 8, 2020
For convenience, TempFile in io/ioutil now has a link to the document.

Updates #36878

Change-Id: I5c22f57c886badd8ca423e34527c4b4bb029847b
Reviewed-on: https://go-review.googlesource.com/c/go/+/218637
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
gopherbot pushed a commit that referenced this issue Feb 8, 2020
"Minor changes to the library" are basically arranged in alphabetical
order, but there are some mistakes so we will correct them.

Updates #36878

Change-Id: I8498563b739eff9f1b0a76ead3cf290191e0ce36
Reviewed-on: https://go-review.googlesource.com/c/go/+/218638
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 10, 2020

Change https://golang.org/cl/218918 mentions this issue: doc/go1.14: add a couple minor crypto release notes

gopherbot pushed a commit that referenced this issue Feb 10, 2020
These were left out of CL 216759 because they are trivial, but I was
advised to be thorough.

Updates #36878

Change-Id: Id4fd3a84866a82265e3f89abfdad6e3d231b507c
Reviewed-on: https://go-review.googlesource.com/c/go/+/218918
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit that referenced this issue Feb 11, 2020
Updates #36878
Fixes #37040

Change-Id: Ib0bd21481e5d9c3b3966c116966ecfe071243a24
Reviewed-on: https://go-review.googlesource.com/c/go/+/218297
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@posener

This comment has been minimized.

Copy link

@posener posener commented Feb 14, 2020

Should "context got faster" also be in the release notes?
https://go-review.googlesource.com/c/go/+/196521

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Feb 15, 2020

@posener It doesn't seem necessary to me. There are many performance improvements. This one doesn't seem worth calling out specially; I doubt it would cause anybody to change their programming patterns.

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Feb 18, 2020

I plan to send a CL to highlight the hash/maphash package as a more noteworthy change to the standard library, rather than letting it stay in the middle of "Minor changes to the library" section. It is a new package that did not exist before, so my understanding is that it should be called out. For example, Go 1.13 release notes called out the new crypto/ed25519, and Go 1.9 release notes called out the new math/bits.

Does anyone agree or disagree?

Edit: Sent CL 219877.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 18, 2020

Change https://golang.org/cl/219877 mentions this issue: doc/go1.14: highlight the addition of hash/maphash package

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Feb 18, 2020

I noticed we overlooked a TODO in a comment in the Go 1.14 release notes (only visible when viewing source):

<!-- TODO: Maybe CL 200439? -->

We should resolve that TODO either by mentioning that CL in the Go 1.14 release notes, or not doing that and deleting the "maybe" comment.

@mknyszek @aclements Do you have an opinion on which is better?

@aclements

This comment has been minimized.

Copy link
Member

@aclements aclements commented Feb 18, 2020

<!-- TODO: Maybe CL 200439? -->

I'm inclined to not mention this. I think explaining this is just too subtle and it shouldn't affect many users. Unless, @mknyszek, do you think you could come up with a straightforward user-facing explanation of the consequences of that change?

@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Feb 18, 2020

@aclements I think you're right, and I cannot. I don't want to discourage users from filings bugs about changes in their application's behavior (especially if its for the worse) by implying that the runtime got slower in exchange for memory use, and I can't think of a straight-forward wording that doesn't have this connotation.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 18, 2020

Change https://golang.org/cl/219898 mentions this issue: doc/go1.14: remove TODO comment for CL 200439

gopherbot pushed a commit that referenced this issue Feb 18, 2020
Based on https://golang.org/issue/36878#issuecomment-587533153
and https://golang.org/issue/36878#issuecomment-587549692,
this is not a CL that needs to be mentioned in the release notes.

Updates #36878

Change-Id: Icaa9153da7481a1d3ebabc237411539dd770cef2
Reviewed-on: https://go-review.googlesource.com/c/go/+/219898
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit that referenced this issue Feb 18, 2020
Given that it's a package that did not exist before, was a proposal
in issue #28322, got accepted and implemented for 1.14, it seems to
be more than a minor change to the library. Highlight it accordingly.

Also specify the results are 64-bit integers, as done in CL 219340.

Updates #36878
Updates #28322

Change-Id: Idefe63d4c47a02cdcf8be8ab08c40cdb94ff2098
Reviewed-on: https://go-review.googlesource.com/c/go/+/219877
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Toshihiro Shiino <shiino.toshihiro@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 24, 2020

Change https://golang.org/cl/220646 mentions this issue: doc/go1.14: remove draft notice

@gopherbot gopherbot closed this in 1c0d664 Feb 24, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 24, 2020

Change https://golang.org/cl/220650 mentions this issue: [release-branch.go1.14] doc/go1.14: remove draft notice

gopherbot pushed a commit that referenced this issue Feb 24, 2020
Use consistent indentation for one of the paragraphs.

Include issue number in the visible text, so it is easier to read.

Updates #36878

Change-Id: Iab857b26b1d27b0137e981126207089db108d530
Reviewed-on: https://go-review.googlesource.com/c/go/+/220646
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 1c0d664)
Reviewed-on: https://go-review.googlesource.com/c/go/+/220650
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 25, 2020

Change https://golang.org/cl/220906 mentions this issue: doc/go1.14: add link to module migration guide

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 25, 2020

Change https://golang.org/cl/220981 mentions this issue: [release-branch.go1.14] doc/go1.14: add link to module migration guide

gopherbot pushed a commit that referenced this issue Feb 25, 2020
Adding a link to this guide will provide more value to instructing Go
users to migrate to modules.

Updates #36878

Change-Id: Ie6ab45efcd35cc5e5ba5adc16ba0ca4cca4292bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/220906
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: thepudds <thepudds1460@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Feb 25, 2020
Adding a link to this guide will provide more value to instructing Go
users to migrate to modules.

Updates #36878

Change-Id: Ie6ab45efcd35cc5e5ba5adc16ba0ca4cca4292bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/220906
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: thepudds <thepudds1460@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 8e2dad5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/220981
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.