Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support case insensitive file systems #36904

Open
stamblerre opened this issue Jan 30, 2020 · 2 comments
Open

x/tools/gopls: support case insensitive file systems #36904

stamblerre opened this issue Jan 30, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 30, 2020

gopls doesn't support case-insensitive file systems. VS Code always sends lower-case drive letters, but if a user sets their GOPATH to C://bob/go, go list will return upper-case drive letters. At that point, gopls will think it did not get metadata for the given file, and it will not work correctly.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 30, 2020
@stamblerre stamblerre changed the title x/tools/gopls: don't support case insensitive file systems x/tools/gopls: support case insensitive file systems Jan 30, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 30, 2020

Change https://golang.org/cl/217080 mentions this issue: internal/span: always uppercase the drive letter for Windows

gopherbot pushed a commit to golang/tools that referenced this issue Jan 30, 2020
Drive letters are always case-insensitive, so we should standardize them
by always keeping them uppercase.

Updates golang/go#36904

Change-Id: I8de25b175790b01627f947600c1511edf38c316c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217080
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 30, 2020

Change https://golang.org/cl/217088 mentions this issue: internal/span: always uppercase the drive letter for Windows

gopherbot pushed a commit to golang/tools that referenced this issue Jan 30, 2020
Drive letters are always case-insensitive, so we should standardize them
by always keeping them uppercase.

Updates golang/go#36904

Change-Id: I8de25b175790b01627f947600c1511edf38c316c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217080
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 0725381)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217088
Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.