Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: investigate possibility of supporting Go tests that require use of Docker in trybots/builders #37633
We would like the trybots to be able to run a docker container.
The discovery site needs a postgres database to run tests, and we've been starting it in our CI with
An alternative would be to install postgres in the trybot image, but that's probably more difficult and definitely less general.
Yep, I discussed this with Jonathan (thanks @jba for posting this issue). I think this might not be possible with the current Trybot implementation. For example, exposing Docker probably means exposing sudoless docker, which comes with a bunch of security concerns.
Another option might be to integrate TryBot functionality with other CI tooling, for example Cloud Build. TryBots have many nice features (e.g. gating on Run-Trybots +1) that could perhaps be separated from the actual CI.