-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: investigate possibility of supporting Go tests that require use of Docker in trybots/builders #37633
Comments
IIRC it may have been @findleyr that had the same feature requests for x/tools trybots. |
@jba Docker does not support every platform that Go supports and gets tested on. Is the scope of this feature request limited to a subset of GOOS/GOARCH pairs? For example, just |
If the target for the discovery site is always Docker, an alternative would be to configure a Cloud Build run to be able to publish Trybot results, rather than using the normal Trybots for this specific scenario. |
Yep, I discussed this with Jonathan (thanks @jba for posting this issue). I think this might not be possible with the current Trybot implementation. For example, exposing Docker probably means exposing sudoless docker, which comes with a bunch of security concerns. Another option might be to integrate TryBot functionality with other CI tooling, for example Cloud Build. TryBots have many nice features (e.g. gating on Run-Trybots +1) that could perhaps be separated from the actual CI. |
If you're using Cloud Build, it might not be necessary to gate |
Perhaps, though I'd prefer still gating on Another feature is hosting artifacts in a public GCS bucket, and posting them back to the the CL (not something GCB does out of the box). |
Could the trybots execute a That would give us gating, but not public artifacts. It would imply that the trybots have some sort of GCP auth on them. |
We would like the trybots to be able to run a docker container.
The discovery site needs a postgres database to run tests, and we've been starting it in our CI with
docker run
.An alternative would be to install postgres in the trybot image, but that's probably more difficult and definitely less general.
The text was updated successfully, but these errors were encountered: