net/http: document fields set in Request.URL in handler

[gopherbot]

by kelwert@mtu.edu:

I'm not entirely sure which of these should be missing, but, when using
http.ListenAndServe, it appears, that in the URL field, a good number of the fields are
missing that should be set.

r.URL.Opaque is empty
r.URL.User is nil, even when a username is passed, though I'm not 100% sure with this one
r.URL.Host is not set. This is really just an inconvenience. It can be hacked around
with r.URL.Host = r.Host
r.URL.Fragment is empty
r.URL.Scheme is empty.

These were tested using localhost, so I could understand if Host wasn't set (though, I
think it probably should be), but Scheme should really be set.

This is relatively simple to reproduce. Just set up a handler for http.ListenAndServe
and check what's set in r.URL.

[gopherbot]

Comment 1 by kelwert@mtu.edu:

Notes: This appears to be the case in stable and from the tip.

[davecheney]

Comment 2:

Some additional details:
lucky(~/src) go run http.go &
[1] 2170
lucky(~/src) % curl http://alice:bob@lucky.local:8080/foo/bar?baz#flobble
&url.URL{Scheme:"", Opaque:"", User:(*url.Userinfo)(nil), Host:"", Path:"/foo/bar",
RawQuery:"baz", Fragment:""}
&http.Request{Method:"GET", URL:(*url.URL)(0xf8400683f0), Proto:"HTTP/1.1",
ProtoMajor:1, ProtoMinor:1, Header:http.Header{"Authorization":[]string{"Basic
YWxpY2U6Ym9i"}, "User-Agent":[]string{"curl/7.22.0 (x86_64-pc-linux-gnu) libcurl/7.22.0
OpenSSL/1.0.1 zlib/1.2.3.4 libidn/1.23 librtmp/2.3"}, "Accept":[]string{"*/*"}},
Body:(*http.body)(0xf84007a740), ContentLength:0, TransferEncoding:[]string(nil),
Close:false, Host:"lucky.local:8080", Form:url.Values(nil), PostForm:url.Values(nil),
MultipartForm:(*multipart.Form)(nil), Trailer:http.Header(nil),
RemoteAddr:"192.168.1.25:56773", RequestURI:"/foo/bar?baz",
TLS:(*tls.ConnectionState)(nil)}

Attachments:

1. http.go (246 bytes)

[bradfitz]

Comment 3:

Fragments are never sent in HTTP.  They're purely a local browser concept.
Opaque and Fragment should not be set. Scheme isn't necessarily known... the HTTP
package just uses a listener.  It doesn't know the details of how a connection was made.
 Although I'm sure we could hack it to make it work for the common two types.

[gopherbot]

Comment 4 by kelwert@mtu.edu:

Shouldn't Host be set though?

[rsc]

Comment 6:

This seems to me mainly a doc fix.
If the request said GET /foo then r.URL.Host will be empty.
If the request said GET http://you.com/foo then r.URL.Host will be "you.com". But that's
only common in proxies.
r.Host is the convenience, the effective host regardless of the request form. r.URL
tells you what was sent in the GET line.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 7:

Labels changed: added go1.1.

[rsc]

Comment 8:

Labels changed: added size-s.

[rsc]

Comment 9:

Labels changed: added suggested.

[rsc]

Comment 10:

This issue was closed by revision 948f0b7.

Status changed to Fixed.