encoding/json: marshal result of string type struct field with ",string" option change in go1.14 [1.14 backport]

[gopherbot]

@mvdan requested issue #38173 to be considered for backport to the next 1.14 minor release.

@gopherbot, please open a backport issue for 1.14.

I think this is a regression - https://go-review.googlesource.com/c/go/+/193604 was a good change, but we didn't properly think of all the edge cases. I have a fix nearly ready. CC @breml @dsnet

[mvdan]

The CL fixing this issue has been available since March - it's proving difficult to get the change properly approved during this time, so any help is appreciated. It would be a shame for it to get pushed back to 1.14.4 once again.

[dmitshur]

Approved as this is a Go 1.14-specific regression with no workaround.

[gopherbot]

Change https://golang.org/cl/233037 mentions this issue: [release-branch.go1.14] encoding/json: properly encode strings with ",string" again

[gopherbot]

Closed by merging 8ca58ff to release-branch.go1.14.