testing: streaming output loses parallel subtest associations [1.14 backport] #39308
Comments
|
@bcmills Do I understand correctly that backporting this to 1.14 will improve readability of the test output for humans, and fix a bug in Does the fix involve backporting both CL 229085 and CL 235997? |
|
Yes, your understanding of the behavior change is correct. I would recommend backporting both changes, although only the first one is strictly necessary to fix the bug. You'll also want to pull in CL 234978 either way. |
|
Thanks. We've discussed this in a release meeting yesterday, and while it's unfortunate to be making a change, it is fixing a serious issue without a workaround. Approving for 1.14 (this issue doesn't affect 1.13). |
|
in minikube CI we have a bug (kubernetes/minikube#8349) that depends on fixing this issue |
|
Change https://golang.org/cl/242058 mentions this issue: |
|
Change https://golang.org/cl/242057 mentions this issue: |
|
Change https://golang.org/cl/242059 mentions this issue: |
|
Closed by merging 2ba9d45 to release-branch.go1.14. |
In #24929, we decided to stream chatty test output. It looks like, foo_test.go:138: TestFoo/sub-1: hello from subtest 1 foo_test.go:138: TestFoo/sub-2: hello from subtest 2 In this CL, we refactor the output to be grouped by === CONT lines, preserving the old test-file-before-log-line behavior: === CONT TestFoo/sub-1 foo_test.go:138 hello from subtest 1 === CONT TestFoo/sub-2 foo_test.go:138 hello from subtest 2 This should remove a layer of verbosity from tests, and make it easier to group together related lines. It also returns to a more familiar format (the pre-streaming format), whilst still preserving the streaming feature. Updates #38458. Fixes #39308. Change-Id: Iaef94c580d69cdd541b2ef055aa004f50d72d078 Reviewed-on: https://go-review.googlesource.com/c/go/+/229085 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Andrew Bonventre <andybons@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/242057 Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Jean de Klerk <deklerk@google.com>
…amd64 builder The parallel chatty tests added in CL 229085 fail on the solaris-amd64-oraclerel builder, because a +NN:NN offset time zone is used. Allow for the `+` character in the corresponding regex to fix these tests. Also move the '-' to the end of the character class, so it is not interpreted as the range 9-T. Updates #38458. For #39308. Change-Id: Iec9ae82ba45d2490176f274f0dc6812666eae718 Reviewed-on: https://go-review.googlesource.com/c/go/+/234978 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/242059 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
… FAIL lines This fixes an issue raised at #38458 (comment) in which --- PASS and --- FAIL lines would not trigger --- CONT lines of other tests. Updates #38458. For #39308. Change-Id: I0d8cc54d682a370d0a6ea6816a11b2e462a92efe Reviewed-on: https://go-review.googlesource.com/c/go/+/235997 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/242058 Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
|
Now that this change was submitted to the release branch, I'll remove release-blocker label to reduce visual noise when viewing the release history details. |
Includes the security patches from go14.5 and golang/go#39308 to fix our test logs.
@bcmills requested issue #38458 to be considered for backport to the next 1.14 minor release.
The text was updated successfully, but these errors were encountered: