Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: streaming output loses parallel subtest associations [1.14 backport] #39308

Open
gopherbot opened this issue May 28, 2020 · 5 comments
Open

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 28, 2020

@bcmills requested issue #38458 to be considered for backport to the next 1.14 minor release.

@gopherbot, please backport to Go 1.14: the 1.14 output format breaks go test -json for parallel subtests, and backporting the fix to the output format is likely to be more maintainable than a one-off test2json fix that is only used for the 1.14 branch.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 4, 2020

@bcmills Do I understand correctly that backporting this to 1.14 will improve readability of the test output for humans, and fix a bug in go test -json (used by machines), so the behavior change from backporting it should be safe for a minor release?

Does the fix involve backporting both CL 229085 and CL 235997?

@bcmills
Copy link
Member

@bcmills bcmills commented Jun 4, 2020

Yes, your understanding of the behavior change is correct.

I would recommend backporting both changes, although only the first one is strictly necessary to fix the bug. You'll also want to pull in CL 234978 either way.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 5, 2020

Thanks.

We've discussed this in a release meeting yesterday, and while it's unfortunate to be making a change, it is fixing a serious issue without a workaround. Approving for 1.14 (this issue doesn't affect 1.13).

@mdwhatcott
Copy link

@mdwhatcott mdwhatcott commented Jun 11, 2020

@bcmills - Is this on track for 1.14.5?

@medyagh
Copy link

@medyagh medyagh commented Jun 16, 2020

in minikube CI we have a bug (kubernetes/minikube#8349) that depends on fixing this issue
more info here
#33419 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.