Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmg/go: TestScript/mod_gomodcache and TestScript/generate_env are failing on Plan 9 #39599

Closed
fhs opened this issue Jun 15, 2020 · 2 comments
Closed

Comments

@fhs
Copy link
Contributor

@fhs fhs commented Jun 15, 2020

$ go version
go version devel +master Sun Jun 14 23:36:00 EDT 2020 plan9/amd64
% cd src
% ./all.rc
...

--- FAIL: TestScript (0.05s)
    --- FAIL: TestScript/mod_gomodcache (7.47s)
        script_test.go:210: 
            # Test GOMODCACHE (0.000s)
            # Explicitly set GOMODCACHE (3.183s)
            # Ensure GOMODCACHE doesn't affect location of sumdb, but $GOMODCACHE/cache/download/sumdb is still written (0.001s)
            # Test that the default GOMODCACHE is $GOPATH[0]/pkg/mod (3.160s)
            # If neither GOMODCACHE or GOPATH are set, GOPATH defaults to the user's $HOME/go, so GOMODCACHE becomes $HOME/go/pkg/mod (0.993s)
            > [windows] env USERPROFILE=$WORK/home # Ensure USERPROFILE is a valid path (rather than /no-home/ so we don't run into the logic that "uninfers" GOPATH in cmd/go/main.go
            > [!windows] env HOME=$WORK/home
            > env GOMODCACHE=
            > env GOPATH=
            > go env GOMODCACHE
            [stdout]
            /no-home/go/pkg/mod
            > stdout $HOME[/\\]go[/\\]pkg[/\\]mod
            FAIL: testdata/script/mod_gomodcache.txt:31: no match for `(?m)\$WORK/home[/\\]go[/\\]pkg[/\\]mod` found in stdout
            
    --- FAIL: TestScript/generate_env (6.77s)
        script_test.go:210: 
            # Install an env command because Windows and plan9 don't have it. (5.694s)
            # Test generators have access to the environment (1.037s)
            > go generate ./printenv.go
            [stderr]
            printenv.go:3: running "env": exec: "env": executable file not found in $path
            [exit status: 'go 77512: 1']
            FAIL: testdata/script/generate_env.txt:7: unexpected command failure
...

@gopherbot add labels OS-Plan9, Testing

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 15, 2020

Change https://golang.org/cl/237941 mentions this issue: cmd/go: fix mod_gomodcache and generate_env TestScripts on Plan 9

@andybons andybons added the NeedsFix label Jun 15, 2020
@andybons andybons added this to the Unplanned milestone Jun 15, 2020
@bcmills bcmills modified the milestones: Unplanned, Go1.15 Jun 16, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Jun 16, 2020

Milestoning to 1.15, since this fixes a broken test and has a (trivial) open CL.

@gopherbot gopherbot closed this in 9ca2474 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.