Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/pkgsite: "Search help" button is too conspicuous #40624
What is the URL of the page with the issue?
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.59 Safari/537.36
What did you do?
Visited the page.
What did you expect to see?
A clean layout with items sized according to their importance.
What did you see instead?
My workflow with pkg.go.dev looks like this:
It's a minor point, but I find that my eye is consistently drawn/distracted by the "Search help" button. It's as large/prominent as the "Search" button, even more so perhaps because it (the help button) has an icon.
Could this not be relegated to a "Need help?" link below the examples? The example are already some form of "help", so adding a link beneath them is not that much of a stretch.
Or perhaps a help icon to the right of the search input box itself?
Prior art here is the google.com homepage - where I note there isn't even a help link (which is less useful to my mind)!
I agree, the search help link looks like a button itself, and on systems that order the primary action button to the left (e.g., macOS and most Linux desktops), it's in the exact area you would look to find the primary button. I like Paul's suggested solution, but whichever approach we take, we should ensure that it 1) makes this look less like a button, and 2) moves it out of the primary focus area for macOS and Linux users.
This change adds various a11y fixes and reconfigures the search help button. Updates golang/go#40624 Change-Id: Ifaad23aca326a8d88b55d0385eed16d32ddea85c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/254878 Trust: Jamal Carvalho <firstname.lastname@example.org> Run-TryBot: Jamal Carvalho <email@example.com> Reviewed-by: Julie Qiu <firstname.lastname@example.org>