Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
go/packages: switch to native overlays for 1.16 #41598
It's looking like we will need to get the Go version for every call to packages.Load.
@heschik: Would it be reasonable to cache the go version in the go command runner, and consequently, enforce a requirement that a given runner can only be used with a single
There is currently no clear rule about what the lifetime/scope of a Runner is, and it's currently one per gopls session, so that would definitely not be correct given differing environments.
We already do multiple go command invocations per Load call (size loading, in particular) and I don't think this is the time to try to reduce them. That said, I think the approach I took in
It seems easier to have this as a shared internal function. Updates golang/go#41598 Change-Id: If35bdbdf5499624dd55ae9daede1ff1ae9495026 Reviewed-on: https://go-review.googlesource.com/c/tools/+/263985 Trust: Rebecca Stambler <email@example.com> Run-TryBot: Rebecca Stambler <firstname.lastname@example.org> gopls-CI: kokoro <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Reviewed-by: Peter Weinberger <email@example.com> Reviewed-by: Heschi Kreinick <firstname.lastname@example.org>