Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: invalid instruction: MOVL $11553462026240, AX [1.15 backport] #41720

Closed
gopherbot opened this issue Sep 30, 2020 · 4 comments
Closed

cmd/compile: invalid instruction: MOVL $11553462026240, AX [1.15 backport] #41720

gopherbot opened this issue Sep 30, 2020 · 4 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.15.3

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 30, 2020

@randall77 requested issue #41711 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport issue for 1.15.
@gopherbot gopherbot mentioned this issue Sep 30, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.3 milestone Sep 30, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 1, 2020

Change https://golang.org/cl/258817 mentions this issue: [release-branch.go1.15] cmd/compile: fix left shift constant folding rule

Loading

@randall77
Copy link
Contributor

@randall77 randall77 commented Oct 1, 2020

This issue causes a rare compiler ICE.

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 8, 2020

Approving per discussion in a release meeting as a serious issue without a workaround. Only Go 1.15 needs this backport.

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Oct 14, 2020

Closed by merging 7863f74 to release-branch.go1.15.

Loading

@gopherbot gopherbot closed this Oct 14, 2020
gopherbot pushed a commit that referenced this issue Oct 14, 2020
@randall77 @toothrot
[release-branch.go1.15] cmd/compile: fix left shift constant folding …
7863f74 
…rule

The 32-bit left shift constant folding rule should keep its result
properly sign extended.

Fixes #41720
Fixes #41711

Change-Id: I0fc74444d444274e911952e1725dab0b7737a846
Reviewed-on: https://go-review.googlesource.com/c/go/+/258817
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
claucece added a commit to claucece/go that referenced this issue Oct 22, 2020
@randall77 @claucece
[release-branch.go1.15] cmd/compile: fix left shift constant folding …
e09e4e7 
…rule

The 32-bit left shift constant folding rule should keep its result
properly sign extended.

Fixes golang#41720
Fixes golang#41711

Change-Id: I0fc74444d444274e911952e1725dab0b7737a846
Reviewed-on: https://go-review.googlesource.com/c/go/+/258817
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.15.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dmitshur @randall77 @gopherbot