Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: inform user about excluded/orphaned files due to nested or multiple modules #42109

Open
stamblerre opened this issue Oct 21, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 21, 2020

When a workspace contains multiple modules without experimentalWorkspaceModule, some of the modules may be excluded or ignored. We should show a diagnostic on every opened "excluded" file (analogous to the build tag diagnostics) that informs the user of the issue and redirects them to clear documentation on how to add workspace folders or enable experimentalWorkspaceModule.

@gopherbot gopherbot added this to the Unreleased milestone Oct 21, 2020
@stamblerre stamblerre added the Soon label Oct 30, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre changed the title x/tools/gopls: show diagnostics for excluded/orphaned files x/tools/gopls: inform user about excluded/orphaned files due to nested or multiple modules Nov 11, 2020
@stamblerre stamblerre self-assigned this Nov 23, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 23, 2020

Change https://golang.org/cl/272346 mentions this issue: internal/lsp: improve errors in multi-module workspaces (GO111MODULE=on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.