x/tools/gopls: upgrade direct dependencies does not work

[wtask]

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go
  • go version go1.15.5 windows/amd64
• Run gopls -v version to get version of Gopls if you are using the language server.
  • v0.5.4
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
  • 1.51.1
    e5a624b788d92b8d34d1392e4c4d9789406efe8f
    x64
• Check your installed extensions to get the version of the VS Code Go extension
  • 0.19.0
• Run go env to get the go development environment details
  set GO111MODULE=on
  set GOARCH=amd64
  set GOBIN=c:\dev\go\bin
  set GOCACHE=C:\Users\webta\AppData\Local\go-build
  set GOENV=C:\Users\webta\AppData\Roaming\go\env
  set GOEXE=.exe
  set GOFLAGS=
  set GOHOSTARCH=amd64
  set GOHOSTOS=windows
  set GOINSECURE=
  set GOMODCACHE=C:\dev\go\pkg\mod
  set GONOPROXY=gitlab.XXX
  set GONOSUMDB=gitlab.XXX
  set GOOS=windows
  set GOPATH=C:\dev\go
  set GOPRIVATE=gitlab.XXX
  set GOPROXY=https://proxy.golang.org,direct
  set GOROOT=c:\go
  set GOSUMDB=sum.golang.org
  set GOTMPDIR=
  set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
  set GCCGO=gccgo
  set AR=ar
  set CC=gcc
  set CXX=g++
  set CGO_ENABLED=1
  set GOMOD=NUL
  set CGO_CFLAGS=-g -O2
  set CGO_CPPFLAGS=
  set CGO_CXXFLAGS=-g -O2
  set CGO_FFLAGS=-g -O2
  set CGO_LDFLAGS=-g -O2
  set PKG_CONFIG=pkg-config
  set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\webta\AppData\Local\Temp\go-build547893570=/tmp/go-build -gno-record-gcc-switches

Describe the bug

So bug description is in the title for this issue.

Steps to reproduce the behavior:

1. Open your go.mod in the editor.
2. Wait a little time to appear update suggestions above dependencies references... Wait... Nothing happen.
3. Downgrade gopls go get golang.org/x/tools/gopls@v0.5.3 and restart vscode
4. Repeat 1-2 and see the suggestions is appeared.

[hyangah]

Thanks for the report. @wtask Indeed, I could reproduce this with v0.5.4 and the version built at head (git clone & go install from gopls directory). I don't see any explicit mention of this change yet from the release note so not sure if it's an intended change or not. Transferring to the gopls issue tracker to triage.

[heschik]

This was indeed a deliberate change (https://golang.org/cl/271297) that we missed in the release notes.

[stamblerre]

Thanks for this catch, just updated the release notes to include this. #38339 tracks the way in which we will rework this behavior--we will likely expose a code action that offers an upgrade when you click on the require line. (Release notes)

[stamblerre]

Duplicate of #38339

[wtask]

@stamblerre Does it mean that gopls v0.5.4 drops any support for per-dependency updates notification? And only Upgrade All option will be available? Painful, unhappy coding. I never saw "Upgrade all dependencies" for my go.mod, what is this?

[wtask]

As for me, per-dependency update notification is very useful feature of vscode-go, and now it is absent. So I have to stay on gopls v0.5.3

[majst01]

I also miss this feature heavily, the "upgrade all dependencies" at the top of the file is not very helpful, because this wont work for most of the projects which depend on k8s.io/*.

So would be very nice if at least the old behavior could be enabled on will again.

[wtask]

@majst01 I found only this helper https://github.com/psampaz/go-mod-outdated to replace missed feature, but it's inconvenient.

[stamblerre]

I also miss this feature heavily, the "upgrade all dependencies" at the top of the file is not very helpful, because this wont work for most of the projects which depend on k8s.io/*.

@majst01: Do you mind explaining why that is?

#38339 tracks our work in replacing this feature--we will be adding an "Update direct dependencies" code lens in the next release.

[majst01]

@stamblerre of course. If you have a project which relies on some kubernetes dependencies, updating all dependencies for various reasons. The most obvious is that k8s.io/client-go must follow the other k8s.io dependencies like k8s.io/apimachinery, but the most recent version of client-go is v11.x which is based on an older versioning scheme back then. In reality the actual version is v0.19.4. With this situation alone it is not possible anymore to update any dependencies from vscode, because client-go v11.x is not compatible with k8s.io/apimachinery v0.19.x. The update all dependencies action will not succeed, and you have to update every dependency by hand.

I am sure lot of developers have the same problem i describe here.

One example from of our projects is the cloud controller manager for metal-stack.io
https://github.com/metal-stack/metal-ccm
This is a small project, but has lots of k8s.io dependencies because this is the way cloud-controller interface has to be implemented.
If you have spare time, check out master and try.

[majst01]

@stamblerre thanks !

[sebrandon1]

Here I thought this was a bug with the latest version of Gopls. Myself and a number of my colleagues really liked the ability to click and update the various go.mod entries. Add my name to the list of people who want this feature re-enabled.

[wtask]

gopls v0.6.0 with "Upgrade direct dependencies" doesn't work. Got git errors. But running the first problematic command from error popup directly in console works as expected go get {dependency}. Unusable feature.
I lightly misunderstanding what is the sense to present blind, unattended batch upgrade for all dependencies? Do you develop vscode-go in the same way? Upgrading all and then will check what is happened?

[stamblerre]

gopls v0.6.0 with "Upgrade direct dependencies" doesn't work. Got git errors.

I would be happy to help investigate what went wrong here if you would like to share the errors.

Please note, you can always update your dependencies on the command line by running go get {dependency}--that's all the individual upgrade code lenses were doing. While this editor feature was convenient, its absence should not prevent you from upgrading individual dependencies.

As I have noted previously, the granular updates posed performance concerns, and many users found them distracting (especially if they did not want to upgrade). We are revisiting this UX and will likely bring back the feature in a different form. Until then, best path forward would be to upgrade individual dependencies using the command-line.

[wtask]

If user do not want to upgrade, why to click an update link? Note, I just really do not understand why cool feature is removed and replaces by strange, blind functionality? Also, if I have to updrade all I will run go get -u ./... under module root and will see all messages from go get. So I could able to resolve any problem if it will happen. Instead the vscode-go and gopls teams make me install additional tools to know which updates are available and manually update them. I like vscode-go very much, but today I have a regression of my workflow.
As for "Upgrade direct dependencies" I only tried to test this function and I'm not planned to add issue report anyway due to "upgrade all" action is always unsafe for me. Will just avoid it.