x/tools/gopls: re-enable upgrade lenses for individual dependencies

[wtask]

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go
  • go version go1.15.5 windows/amd64
• Run gopls -v version to get version of Gopls if you are using the language server.
  • v0.5.4
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
  • 1.51.1
    e5a624b788d92b8d34d1392e4c4d9789406efe8f
    x64
• Check your installed extensions to get the version of the VS Code Go extension
  • 0.19.0
• Run go env to get the go development environment details
  set GO111MODULE=on
  set GOARCH=amd64
  set GOBIN=c:\dev\go\bin
  set GOCACHE=C:\Users\webta\AppData\Local\go-build
  set GOENV=C:\Users\webta\AppData\Roaming\go\env
  set GOEXE=.exe
  set GOFLAGS=
  set GOHOSTARCH=amd64
  set GOHOSTOS=windows
  set GOINSECURE=
  set GOMODCACHE=C:\dev\go\pkg\mod
  set GONOPROXY=gitlab.XXX
  set GONOSUMDB=gitlab.XXX
  set GOOS=windows
  set GOPATH=C:\dev\go
  set GOPRIVATE=gitlab.XXX
  set GOPROXY=https://proxy.golang.org,direct
  set GOROOT=c:\go
  set GOSUMDB=sum.golang.org
  set GOTMPDIR=
  set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
  set GCCGO=gccgo
  set AR=ar
  set CC=gcc
  set CXX=g++
  set CGO_ENABLED=1
  set GOMOD=NUL
  set CGO_CFLAGS=-g -O2
  set CGO_CPPFLAGS=
  set CGO_CXXFLAGS=-g -O2
  set CGO_FFLAGS=-g -O2
  set CGO_LDFLAGS=-g -O2
  set PKG_CONFIG=pkg-config
  set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\webta\AppData\Local\Temp\go-build547893570=/tmp/go-build -gno-record-gcc-switches

Describe the bug

So bug description is in the title for this issue.

Steps to reproduce the behavior:

1. Open your go.mod in the editor.
2. Wait a little time to appear update suggestions above dependencies references... Wait... Nothing happen.
3. Downgrade gopls go get golang.org/x/tools/gopls@v0.5.3 and restart vscode
4. Repeat 1-2 and see the suggestions is appeared.

[hyangah]

Thanks for the report. @wtask Indeed, I could reproduce this with v0.5.4 and the version built at head (git clone & go install from gopls directory). I don't see any explicit mention of this change yet from the release note so not sure if it's an intended change or not. Transferring to the gopls issue tracker to triage.

[heschi]

This was indeed a deliberate change (https://golang.org/cl/271297) that we missed in the release notes.

[stamblerre]

Thanks for this catch, just updated the release notes to include this. #38339 tracks the way in which we will rework this behavior--we will likely expose a code action that offers an upgrade when you click on the require line. (Release notes)

[stamblerre]

Duplicate of #38339

[wtask]

@stamblerre Does it mean that gopls v0.5.4 drops any support for per-dependency updates notification? And only Upgrade All option will be available? Painful, unhappy coding. I never saw "Upgrade all dependencies" for my go.mod, what is this?

[wtask]

As for me, per-dependency update notification is very useful feature of vscode-go, and now it is absent. So I have to stay on gopls v0.5.3

[majst01]

I also miss this feature heavily, the "upgrade all dependencies" at the top of the file is not very helpful, because this wont work for most of the projects which depend on k8s.io/*.

So would be very nice if at least the old behavior could be enabled on will again.

[wtask]

@majst01 I found only this helper https://github.com/psampaz/go-mod-outdated to replace missed feature, but it's inconvenient.