Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: Wrap error in NewClientConn #45207

Open
avorima opened this issue Mar 24, 2021 · 2 comments
Open

x/crypto/ssh: Wrap error in NewClientConn #45207

avorima opened this issue Mar 24, 2021 · 2 comments
Labels
NeedsInvestigation
Milestone

Comments

@avorima
Copy link

@avorima avorima commented Mar 24, 2021

What version of Go are you using (go version)?

$ go version
go version go1.15.10 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mv/.cache/go-build"
GOENV="/home/mv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/mv/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mv/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/mv/.local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/mv/.local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build650852416=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/CdUXyBdUq2g

What did you expect to see?

Using type assertion or errors.As for things like *net.OpError on errors returned by NewClientConn works.

What did you see instead?

The returned error is a *errors.errorString due to the fact that it's returned using fmt.Errorf and %v instead of %w.

@gopherbot gopherbot added this to the Unreleased milestone Mar 24, 2021
@networkimprov
Copy link

@networkimprov networkimprov commented Mar 27, 2021

cc @FiloSottile

@cagedmantis cagedmantis added the NeedsInvestigation label Mar 29, 2021
@avorima
Copy link
Author

@avorima avorima commented Apr 5, 2021

I see that simply changing the %v to %w won't work due to backwards compatibility issues, so I would propose adding a typed error in the ssh package that implements Unwrap to support error unwrapping for go versions > 1.13 and otherwise behaves like a normal errors.errorString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

4 participants