Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: port of builtins to ABIInternal breaks windows-amd64-regabi builder #45530

Closed
mknyszek opened this issue Apr 12, 2021 · 5 comments
Closed

runtime: port of builtins to ABIInternal breaks windows-amd64-regabi builder #45530

mknyszek opened this issue Apr 12, 2021 · 5 comments
Labels
NeedsInvestigation
Milestone
Go1.17

Comments

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Apr 12, 2021

Failing as of https://golang.org/cl/308931 with:

exit status 0xc0000005

It appears to fail consistently in net/http/internal.

CC @aclements @cherrymui
@mknyszek mknyszek added this to the Go1.17 milestone Apr 12, 2021
@aclements
Copy link
Member

@aclements aclements commented Apr 12, 2021

Failure is in net/http/pprof, actually.

Loading

@aclements
Copy link
Member

@aclements aclements commented Apr 12, 2021

Looks like runtime·externalthreadhandler (in assembly) calls runtime·memclrNoHeapPointers with some very specific assumptions about what it's going to smash or not smash.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 13, 2021

Change https://golang.org/cl/309633 mentions this issue: runtime: use newm for profileloop

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 13, 2021

Change https://golang.org/cl/309634 mentions this issue: runtime: eliminate externalthreadhandler

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 13, 2021

Change https://golang.org/cl/309632 mentions this issue: runtime: use compileCallback for ctrlhandler

Loading

gopherbot pushed a commit that referenced this issue Apr 13, 2021
@aclements
runtime: use compileCallback for ctrlhandler
e512bc2 
This replaces the externalthreadhandler-based implementation of
ctrlhandler with one based on compileCallback. This is a step toward
eliminating externalthreadhandler.

For #45530.

Change-Id: I2de2f2f37777af292db67ccf8057b7566aab81f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/309632
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
gopherbot pushed a commit that referenced this issue Apr 13, 2021
@aclements
runtime: use newm for profileloop
e69f022 
This replaces the externalthreadhandler-based implementation of
profileloop with one that uses newm to start a new thread. This is a
step toward eliminating externalthreadhandler.

For #45530.

Change-Id: Id8e5540423fe2d2004024b649afec6998f77b092
Reviewed-on: https://go-review.googlesource.com/c/go/+/309633
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot gopherbot closed this in c19759a Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation
Projects
None yet
Milestone
Go1.17
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@mknyszek @aclements @gopherbot