cmd/go: fix docs for -test.timeout #4702
Description
by myannikos:
What steps will reproduce the problem?
Run any test that takes longer than 1 minute with
go test -test.bench . -test.timeout 0
What is the expected output?
The test should run forever OR with the default 10 minutes limit (which is not well documented by the way)
What do you see instead?
The test is aborted after 1 minute
Which compiler are you using (5g, 6g, 8g, gccgo)?
6g
Which operating system are you using?
Debian squeeze x86-64
Which version are you using? (run 'go version')
1.0.3
Please provide any additional information below.
This is either a documentation issue:
[go test usage info]
-test.timeout=0: if positive, sets an aggregate time limit for all tests
Or an implementation issue:
pkg/code.google.com/p/go/src/cmd/go/test.go:
// If a test timeout was given and is parseable, set our kill timeout
// to that timeout plus one minute. This is a backup alarm in case
// the test wedges with a goroutine spinning and its background
// timer does not get a chance to fire.
if dt, err := time.ParseDuration(testTimeout); err == nil {
testKillTimeout = dt + 1*time.Minute
}
(this should probably be "parseable and positive")