types2, go/types: need to detect invalid recursive type instantiation

[griesemer]

Per the type parameters proposal:

A generic type can refer to itself in cases where a type can ordinarily refer to itself, but when it does so the type arguments must be the type parameters, listed in the same order.

The type checkers currently don't do this test. Reminder issue.

cc: @findleyr

[findleyr]

Related: #45550.

[griesemer]

Related: #48096.

[findleyr]

This was just reported again in #48671, though in that case the recursion was through a method.

I don't think the same restriction should apply to methods. Consider the following:

func (*List[T]) ToInterfaceList() *List[interface{}]

Somewhat contrived, but one can imagine how something like this could be useful. Perhaps we need logic to detect infinitely expanding instantiation patterns.

[findleyr]

I opened #48703 for infinite recursion through method signatures. It is similar to this issue but requires a different fix.

Also marking this issue as a release blocker.