Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: document that example output must use // (and avoid gofmt flakiness) #4812

Closed
gopherbot opened this issue Feb 15, 2013 · 5 comments
Closed
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2013

by daviddengcn:

Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:

Run "go version" and compare against
http://golang.org/doc/devel/release.html  If a newer version of Go exists,
install it and retry what you did to reproduce the problem.

Thanks.

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1.
2.
3.

What is the expected output?
After "go fmt" my example cases are not failed

What do you see instead?
They are failed by tabs

Which compiler are you using (5g, 6g, 8g, gccgo)?

Which operating system are you using?
MacOS


Which version are you using?  (run 'go version')
1.0.3

Please provide any additional information below.
More information: https://groups.google.com/forum/#!topic/golang-nuts/ZH5YgwmjCXk
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Feb 15, 2013

Comment 1:

Let's document that example output must use // comments.
@natefinch

This comment has been minimized.

Copy link
Contributor

@natefinch natefinch commented Feb 15, 2013

Comment 2:

Is there any interest in just fixing it so that a common indent is stripped off?  An
example here:
http://play.golang.org/p/u5P7NZ_Cvj
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Feb 15, 2013

Comment 3:

I would rather just document it. Stripping common indent is full of
problems too.
@davecheney

This comment has been minimized.

Copy link
Contributor

@davecheney davecheney commented Feb 16, 2013

Comment 4:

Issue #4811 has been merged into this issue.

@adg

This comment has been minimized.

Copy link
Contributor

@adg adg commented Feb 22, 2013

Comment 6:

This issue was closed by revision 2482ef7.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.