Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/netip: add fuzz test comparing with net.ParseIP #49367

Open
FiloSottile opened this issue Nov 4, 2021 · 2 comments
Open

net/netip: add fuzz test comparing with net.ParseIP #49367

FiloSottile opened this issue Nov 4, 2021 · 2 comments

Comments

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Nov 4, 2021

There is an excellent opportunity to write a fuzzer that compares the behaviors of net and netip, to find differences in parsing, serialization, validation, and IsFoo values. Although the internals are different, we probably want them to behave the same, and to document where they diverge intentionally.

It should also catch issues such as #49365.

/cc @katiehockman

@josharian
Copy link
Contributor

@josharian josharian commented Nov 5, 2021

There's an existing go-fuzz based fuzzer that does this and more at github.com/inetaf/netaddr. We should port it.

Loading

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Nov 8, 2021

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants