Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: Incompatibilities with kate editor's LSP client implementation #50922

Open
jurisbu opened this issue Jan 31, 2022 · 1 comment
Open
Labels
gopls Tools
Milestone

Comments

@jurisbu
Copy link

@jurisbu jurisbu commented Jan 31, 2022

Dear gopls developers,

Kate editor implements LSP Client according to specification. There are issues with symbol rename functionality and also organize imports functionality. According to developers, it seems there might be issue with gopls interpretation of protocol specification.

See kate editor bugs:

@gopherbot gopherbot added Tools gopls labels Jan 31, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2022
@findleyr
Copy link
Contributor

@findleyr findleyr commented Jan 31, 2022

As guessed by @leitzler in slace, gopls is not honoring WorkspaceEditClientCapabilities.

This is definitely a gopls bug, and may be straightforward to fix. Unfortunately, I don't think it will make the v0.8.0 milestone as we are prioritizing fixes/features related to Go 1.18.

Having superficially investigated, I think it's just an oversight that we're not supporting the changes API, and might be straightforward to fix.

@findleyr findleyr removed this from the Unreleased milestone Jan 31, 2022
@findleyr findleyr added this to the gopls/on-deck milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Tools
Projects
None yet
Development

No branches or pull requests

3 participants