Skip to content

cmd/go: 'go work use -r' fails to remove entries for deleted subdirectories #50959

@bcmills

Description

@bcmills

What did you do?

go work use -r .
cmp go.work go.work.want

-- go.work --
go 1.18

use (
	.
	sub
	sub/dir/deleted
)
-- go.work.want --
go 1.18

use sub/dir
-- sub/README.txt --
A go.mod file has been deleted from this directory.
In addition, the entire subdirectory sub/dir/deleted
has been deleted, along with sub/dir/deleted/go.mod.
-- sub/dir/go.mod --
module example/sub/dir
go 1.18

What did you expect to see?

go work use -r should delete stale entries for subdirectories of the named directory.

What did you see instead?

            > go work use -r .
            > cmp go.work go.work.want
            [diff -go.work +go.work.want]
             go 1.18

            -use (
            -   sub/dir
            -   sub/dir/deleted
            -)
            +use sub/dir

            FAIL: testdata/script/work_use_deleted.txt:2: go.work and go.work.want differ

(CC @matloob)

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.modules

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions