New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: continuing TestSegv/SegvInCgo failures with "unknown pc" #50979
Comments
This failure mode has now also occurred on Given how rare the failure seems to be and how little time is left in the Go 1.18 cycle, marking as release-blocker for Go 1.19 (instead of 1.18).
2022-02-04T22:34:05-f9763a6/linux-amd64-clang |
|
Four flakes in a month during the testing-lull that is the code freeze makes me think this test is too noisy to leave enabled in the If we aren't going to be able to fix it ahead of the 1.18 release — especially given that one of the failures was observed on a first-class port — I think it at least needs a skip. |
Change https://go.dev/cl/385154 mentions this issue: |
This test has failed on four different builders in the past month. Moreover, because every Go program depends on "runtime", it is likely to be run any time a user runs 'go test all' in their own program. Since the test is known to be flaky, let's skip it to avoid introducing testing noise until someone has time to investigate. It seems like we have enough samples in the builder logs to at least start with. For #50979 Change-Id: I9748a82fbb97d4ed95d6f474427e5aa6ecdb023d Reviewed-on: https://go-review.googlesource.com/c/go/+/385154 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This failure mode is now skipped, so this is no longer a 1.18 release-blocker. (I'll leave it up to @cherrymui and @prattmic to decide whether to prioritize a fix or move it to the Backlog.) |
@prattmic, it looks like the change in the
2022-03-08T21:16:53-c3c7477/linux-mips64le-mengzhuo |
Apologies, I thought I checked for these references, but didn't do a good job. |
Change https://go.dev/cl/391139 mentions this issue: |
CL 390034 changed this throw message to add the goid, breaking the match. For #50979. Change-Id: I52d97695484938701e5b7c269e2caf0c87d44d7a Reviewed-on: https://go-review.googlesource.com/c/go/+/391139 Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
ping -- what's the status of this issue? |
The failures here should be skipped, but we'd still like to investigate. Not a release blocker, though. |
greplogs --dashboard -md -l -e '\Anetbsd-.*(?:\n.*)*FAIL: TestSegv/SegvInCgo .*(?:\n .*)*unknown pc' --since=2022-01-07
2022-02-01T16:10:04-93fe469/netbsd-arm-bsiegert
It is not obvious to me whether this has the same underlying cause as #50605.
(See previously #49182; CC @prattmic @cherrymui.)
The text was updated successfully, but these errors were encountered: