-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: allowModfileModifications when using tempModFile or go.work #51056
Comments
The previous default value for for the config setting ExperimentalAllowModfileModifications was "true", which isn't the default value for gopls. Enabling this setting causes issues with the new workspace mode in gopls as described in #1112 and referred golang/go#48186. It also seem to cause issues in upcoming Go 1.18, see golang/go#51056. Closes #1112
The previous default value for for the config setting ExperimentalAllowModfileModifications was "true", which isn't the default value for gopls. Enabling this setting causes issues with the new workspace mode in gopls as described in #1112 and referred golang/go#48186. It also seem to cause issues in upcoming Go 1.18, see golang/go#51056. Closes #1112
The previous default value for for the config setting ExperimentalAllowModfileModifications was "true", which isn't the default value for gopls. Enabling this setting causes issues with the new workspace mode in gopls as described in #1112 and referred golang/go#48186. It also seem to cause issues in upcoming Go 1.18, see golang/go#51056. Closes #1112
Change https://go.dev/cl/388436 mentions this issue: |
Govim tests expect error messages to use 'any', so build gopls using the RC. For golang/go#51056 Change-Id: I0f8cab5d7eea3efbbd5b3f3dd9918e85831c2d50 Reviewed-on: https://go-review.googlesource.com/c/tools/+/388436 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org>
I have confirmed that our gopls+govim CI is now passing (after updating our build to use RC1). I think allowModfileModifications may still be buggy, but that shouldn't block the gopls@v0.8.0 release. |
Also reported in slack: allowModfileModifications breaks when using go.work: |
govim uses an internal gopls setting:
tempModFile
, along with allowModfileModifications. This appears to be recently broken, perhaps by https://go.dev/cl/382241.Reported in slack, from their CI:
To begin with, this error message is incorrect, as
-modfile
is supported.Needs investigation, and should block gopls@v0.8.0
CC @myitcv @leitzler
The text was updated successfully, but these errors were encountered: