-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Open
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/workspaceIssues related to support for modules or multi-module workspaces.Issues related to support for modules or multi-module workspaces.
Milestone
Description
govim uses an internal gopls setting: tempModFile
, along with allowModfileModifications. This appears to be recently broken, perhaps by https://go.dev/cl/382241.
Reported in slack, from their CI:
&protocol.LogMessageParams{Type:1, Message:"2022/02/07 17:40:55 imports fixes: AllImportsFixes: -modfile is unsupported for this Go version\n\tfile=\"/tmp/go-test-script3721705982/script-initial_open_go/main.go\"\n"}
To begin with, this error message is incorrect, as -modfile
is supported.
Needs investigation, and should block gopls@v0.8.0
Metadata
Metadata
Assignees
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/workspaceIssues related to support for modules or multi-module workspaces.Issues related to support for modules or multi-module workspaces.