dist: tour executable should be tour.exe under windows

[chai2010]

go version
go version devel +d58997478ec6 Mon Apr 08 00:09:35 2013 -0700 windows/386

go tool tour
go tool: no such tool "tour"

[cznic]

Comment 1:

That's correct, see the list of commands here: http://tip.golang.org/cmd/go/
#WorkingAsIntended

[adg]

Comment 2:

"go tool tour" should work, but only for the binary distributions.
It's currently broken, but not related to this issue. See:
https://golang.org/cl/8564043
Are you compiling Go from source? If so, you won't get the tour by default. You'll need
to install it with
  go get code.google.com/p/go-tour/gotour

[chai2010]

Comment 3:

I installed from go1.1beta2.windows-386.zip
And, I try rename $GOROOT\pkg\tool\windows_386\tour to
$GOROOT\pkg\tool\windows_386\tour.exe,
then it can work.

[adg]

Comment 4:

Labels changed: added priority-soon, go1.1, removed priority-triage.

Owner changed to @adg.

Status changed to Accepted.

[adg]

Comment 5:

Thanks for the report.
Started: https://golang.org/cl/8558044

Status changed to Started.

[chai2010]

Comment 6:

I have renamed $GOROOT\pkg\tool\windows_386\tour to
$GOROOT\pkg\tool\windows_386\tour.exe.
But there are still some mistake:
C:\>go tool tour
2013/04/09 16:01:53 Serving content from $GOROOT\misc\tour
2013/04/09 16:01:53 open $GOROOT\misc\tour\js\jquery.js: The system cannot find the path
specified.

[adg]

Comment 7:

This issue was closed by revision 8106381.

Status changed to Fixed.

[adg]

Comment 8:

Thanks, but I already fixed that other issue in a separate change:
https://golang.org/cl/8564043
Please reply to this issue if you still have problems with the release candidate
(probably issued later this week) .

[chai2010]

Comment 9:

I see your change, thanks for your work.
I renamed tour.exe and copy js dir to $(GOROOT)\misc\tour.
It can visit in my browser, and run simple program.
But can not import "code.google.com/p/go-tour/pic".
C:\>go tool tour
2013/04/09 17:44:07 Serving content from $(GOROOT)\misc\tour
2013/04/09 17:44:07 A browser window should open. If not, please visit
http://127.0.0.1:3999
Then, open http://127.0.0.1:3999/#35
// source code
package main
import "code.google.com/p/go-tour/pic"
func Pic(dx, dy int) [][]uint8 {
    mat := make([][]uint8, dy)
    for i := 0; i < dy; i++ {
        mat[i] = make([]uint8, dx)
    }
    //draw
    for y, _ := range mat {
        for x, _ := range mat[y] {
            mat[y][x] = uint8(x^y)
        }
    }
    return mat
}
func main() {
    pic.Show(Pic)
}
Click Run ($GOPATH not set):
compile0.go:3:8: cannot find package "code.google.com/p/go-tour/pic" in any of:
    $(GOROOT)\src\pkg\code.google.com\p\go-tour\pic (from $GOROOT)
    ($GOPATH not set)
Program exited: exit status 1

[adg]

Comment 10:

Wow, it's just bugs upon bugs!
Thanks for finding and reporting this. I think after this change it should be fixed:
https://golang.org/cl/8567043

Status changed to Started.

[adg]

Comment 11:

Status changed to Fixed.

[chai2010]

Comment 12:

Hi, there is the same issue on go1.1rc1.windows{386|amd64}.

[adg]

Comment 13:

My bad. I will rebuild them with the new dist.exe now.

Status changed to Started.

[adg]

Comment 14:

I have replaced the broken go1.1rc1 downloads with fresh ones.

Status changed to Fixed.