Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: frequent TestPreemptionAfterSyscall failures on freebsd-arm-paulzhol #52679

Open
bcmills opened this issue May 3, 2022 · 4 comments
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented May 3, 2022

greplogs -l -e 'FAIL: TestPreemptionAfterSyscall' --since=2022-01-19
2022-05-03T05:42:48-0668e3c/freebsd-arm-paulzhol
2022-05-03T02:12:49-f771edd/freebsd-arm-paulzhol
2022-05-02T21:34:37-99f1bf5/freebsd-arm-paulzhol
2022-04-30T02:35:50-0ebe224/freebsd-arm-paulzhol

See previously #41015 (CC @golang/runtime)

@paulzhol, since freebsd/arm is not a first-class port one option here would be to skip the test on that GOOS+GOARCH. However, it would be better still to diagnose the long hangs in the test. 🤔

@bcmills bcmills added OS-FreeBSD arch-arm Issues solely affecting the 32-bit arm architecture. labels May 3, 2022
@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 9, 2022
@paulzhol
Copy link
Member

paulzhol commented May 14, 2022

TestPreemptionAfterSyscall checks for maxDuration = 5 * time.Second timeout, but I see the builder doesn't miss by that much:

https://build.golang.org/log/fdb8ea8338d74875166d4b47904450c254ca3b49
https://build.golang.org/log/19cc2665e48acd9ebb18ed470f113cb270dc5f8b

Maybe the test should take GO_TEST_TIMEOUT_SCALE into account?

@bcmills
Copy link
Member Author

bcmills commented May 19, 2022

GO_TEST_TIMEOUT_SCALE is usually not appropriate to use directly, since users themselves generally won't set it. (Its main effect is to extend the timeout that the builder sets via the -test.timeout flag.)

If the hard-coded timeout is too short, I wonder if it would make sense to remove it entirely and just check whether the test livelocks..? (It was loosened once already for #41015.)

@bcmills bcmills added this to the Backlog milestone May 19, 2022
@gopherbot
Copy link

gopherbot commented May 26, 2022

Change https://go.dev/cl/408700 mentions this issue: dashboard: add known issue for freebsd-arm-paulzhol

gopherbot pushed a commit to golang/build that referenced this issue May 26, 2022
For golang/go#52653.
Updates golang/go#52679.

Change-Id: I585d0d69d60739328b6921470d7fea0d9c038537
Reviewed-on: https://go-review.googlesource.com/c/build/+/408700
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@gopherbot
Copy link

gopherbot commented Jul 30, 2022

Change https://go.dev/cl/420354 mentions this issue: dashboard: update freebsd-arm-paulzhol Note, remove 52679 from KnownIssues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Projects
Status: Triage Backlog
Development

No branches or pull requests

4 participants