Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: frequent TestPreemptionAfterSyscall failures on freebsd-arm-paulzhol #52679

bcmills opened this issue May 3, 2022 · 2 comments
arch-arm NeedsInvestigation OS-FreeBSD


Copy link

@bcmills bcmills commented May 3, 2022

greplogs -l -e 'FAIL: TestPreemptionAfterSyscall' --since=2022-01-19

See previously #41015 (CC @golang/runtime)

@paulzhol, since freebsd/arm is not a first-class port one option here would be to skip the test on that GOOS+GOARCH. However, it would be better still to diagnose the long hangs in the test. 🤔

@bcmills bcmills added OS-FreeBSD arch-arm labels May 3, 2022
@heschi heschi added the NeedsInvestigation label May 9, 2022
Copy link

@paulzhol paulzhol commented May 14, 2022

TestPreemptionAfterSyscall checks for maxDuration = 5 * time.Second timeout, but I see the builder doesn't miss by that much:

Maybe the test should take GO_TEST_TIMEOUT_SCALE into account?

Copy link
Member Author

@bcmills bcmills commented May 19, 2022

GO_TEST_TIMEOUT_SCALE is usually not appropriate to use directly, since users themselves generally won't set it. (Its main effect is to extend the timeout that the builder sets via the -test.timeout flag.)

If the hard-coded timeout is too short, I wonder if it would make sense to remove it entirely and just check whether the test livelocks..? (It was loosened once already for #41015.)

@bcmills bcmills added this to the Backlog milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
arch-arm NeedsInvestigation OS-FreeBSD
None yet

No branches or pull requests

3 participants