Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: frequent TestPreemptionAfterSyscall failures on freebsd-arm-paulzhol #52679

Open
bcmills opened this issue May 3, 2022 · 4 comments
Open

runtime: frequent TestPreemptionAfterSyscall failures on freebsd-arm-paulzhol #52679

bcmills opened this issue May 3, 2022 · 4 comments
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Milestone
Backlog

Comments

@bcmills
Copy link
Member

bcmills commented May 3, 2022 •
edited 

#!watchflakes
post <- builder == "freebsd-arm-paulzhol" && pkg == "runtime" && test == "TestPreemptionAfterSyscall"

greplogs -l -e 'FAIL: TestPreemptionAfterSyscall' --since=2022-01-19
2022-05-03T05:42:48-0668e3c/freebsd-arm-paulzhol
2022-05-03T02:12:49-f771edd/freebsd-arm-paulzhol
2022-05-02T21:34:37-99f1bf5/freebsd-arm-paulzhol
2022-04-30T02:35:50-0ebe224/freebsd-arm-paulzhol

See previously #41015 (CC @golang/runtime)

@paulzhol, since freebsd/arm is not a first-class port one option here would be to skip the test on that GOOS+GOARCH. However, it would be better still to diagnose the long hangs in the test. 🤔
@bcmills bcmills added OS-FreeBSD arch-arm Issues solely affecting the 32-bit arm architecture. labels May 3, 2022
@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 9, 2022
@paulzhol
Copy link
Member

TestPreemptionAfterSyscall checks for maxDuration = 5 * time.Second timeout, but I see the builder doesn't miss by that much:

https://build.golang.org/log/fdb8ea8338d74875166d4b47904450c254ca3b49
https://build.golang.org/log/19cc2665e48acd9ebb18ed470f113cb270dc5f8b

Maybe the test should take GO_TEST_TIMEOUT_SCALE into account?

@bcmills
Copy link
Member Author

bcmills commented May 19, 2022

GO_TEST_TIMEOUT_SCALE is usually not appropriate to use directly, since users themselves generally won't set it. (Its main effect is to extend the timeout that the builder sets via the -test.timeout flag.)

If the hard-coded timeout is too short, I wonder if it would make sense to remove it entirely and just check whether the test livelocks..? (It was loosened once already for #41015.)

@bcmills bcmills added this to the Backlog milestone May 19, 2022
@gopherbot
Copy link

Change https://go.dev/cl/408700 mentions this issue: dashboard: add known issue for freebsd-arm-paulzhol

gopherbot pushed a commit to golang/build that referenced this issue May 26, 2022
@bcmills @gopherbot
dashboard: add known issue for freebsd-arm-paulzhol
3f0c381 
For golang/go#52653.
Updates golang/go#52679.

Change-Id: I585d0d69d60739328b6921470d7fea0d9c038537
Reviewed-on: https://go-review.googlesource.com/c/build/+/408700
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420354 mentions this issue: dashboard: update freebsd-arm-paulzhol Note, remove 52679 from KnownIssues

@bcmills bcmills mentioned this issue Oct 13, 2022
Open
gopherbot pushed a commit to golang/build that referenced this issue Dec 28, 2022
@paulzhol @gopherbot
dashboard: update freebsd-arm-paulzhol Note, remove 52679 from KnownI…
5b4775e 
…ssues

TestPreemptionAfterSyscall and runtime/pprof no longer fail, after the builder was upgraded.
Hardware wise, it's an ARM Cortex A7 -> Cortex A53 (in 32bit mode).
FreeBSD 13.0 -> 13.1 and also switched from the default SCHED_ULE to SCHED_4BSD.

Update golang/go#52679.

Change-Id: Id2be185992c07d74e43e254cd54133b605b1d06e
Reviewed-on: https://go-review.googlesource.com/c/build/+/420354
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Projects
Go Compiler / Runtime
Status: Triage Backlog
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
4 participants
@paulzhol @bcmills @gopherbot @heschi