Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: release version v0.9.0 #53412

Open
4 of 8 tasks
dle8 opened this issue Jun 16, 2022 · 5 comments
Open
4 of 8 tasks

x/tools/gopls: release version v0.9.0 #53412

dle8 opened this issue Jun 16, 2022 · 5 comments
Labels
gopls Tools
Milestone

Comments

@dle8
Copy link

@dle8 dle8 commented Jun 16, 2022

This issue tracks progress toward releasing gopls@v0.9.0

  • merge master into gopls-release-branch.0.9
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.9.0-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.9.0
@gopherbot gopherbot added Tools gopls labels Jun 16, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 16, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 16, 2022

Change https://go.dev/cl/412815 mentions this issue: all: merge master (c353b05) into gopls-release-branch.0.9

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 16, 2022

Change https://go.dev/cl/412816 mentions this issue: internal/lsp/debug: update hard-coded version for v0.9.0

gopherbot pushed a commit to golang/tools that referenced this issue Jun 16, 2022
Add replace directive for x/tools to gopls/go.mod.

For golang/go#53412

Merge List:

+ 2022-06-16 c353b05 internal/lsp/cache: delete checkSnapshotLocked
+ 2022-06-16 567c98b internal/lsp/cache: don't walk URIs to invalidate metadata
+ 2022-06-16 dffd645 internal/lsp/cache: only clone metadata if something changed
+ 2022-06-16 4ba3d22 internal/lsp/cache: clone the metadata graph when clearing ShouldLoad
+ 2022-06-16 39d3d49 internal/lsp/cache: use metadataGraph.Clone in snapshot.clone
+ 2022-06-16 8a92078 internal/lsp/cache: build a new metadata graph on load
+ 2022-06-16 9f38ef7 internal/lsp/cache: derive workspace packages from metadata
+ 2022-06-16 041035c Revert "internal/lsp/cache: reduce critical sections"
+ 2022-06-16 d097bc9 gopls/internal/vulncheck: include nonaffecting vulnerability info
+ 2022-06-16 e8b9ff1 gopls/internal/govulncheck: sync x/vuln@4eb5ba4
+ 2022-06-15 654a14b internal/lsp/cache: reduce critical sections
+ 2022-06-14 27db7f4 gopls: update golang.org/x/vuln to latest @4eb5ba4
+ 2022-06-14 c993be6 go/analysis/internal/checker: log codeFact error, remove unused action.inputs
+ 2022-06-14 ed27611 internal/lsp/cache: cache known subdirs pattern
+ 2022-06-14 ebc084a internal/lsp: add inlay hints count to test summary
+ 2022-06-13 c15c045 internal/lsp: enable inlay hint tests
+ 2022-06-13 0343989 internal/lsp: fix error message for inlay hints
+ 2022-06-13 a41fc98 internal/lsp/cache: use [256]byte Hash instead of hex digit string
+ 2022-06-10 c41ddce internal/lsp: include padding in inlay hint marker tests
+ 2022-06-10 5e48d26 internal/lsp: add inlay hints for composite literal names
+ 2022-06-10 83b0675 internal/lsp: add inlay hints for constant values
+ 2022-06-10 ecc1479 internal/lsp: add inlay hints for variable types
+ 2022-06-10 65c0181 internal/lsp: support textDocument/inlayHint for parameter names

Change-Id: Idc9bcd1253bbaa32a601867f25472645b104dd05
gopherbot pushed a commit to golang/tools that referenced this issue Jun 16, 2022
Note while we normally set the version to the final version (v0.9.0), we
are anticipating multiple prereleases and so include the prerelease
label to help differentiate them.

For golang/go#53412

Change-Id: I4e01c80ca2edbd18125c8c64d6a697c08cfcf62c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/412816
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Dylan Le <dungtuanle@google.com>
Reviewed-by: Nooras Saba‎ <saba@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 16, 2022

Change https://go.dev/cl/412819 mentions this issue: gopls: update go.mod for v0.9.0-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Jun 16, 2022
Remove the replace directive and update x/tools.

For golang/go#53412

Change-Id: I938f3732449ad7c1bb3df82636cd8ced8251997a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/412819
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dylan Le <dungtuanle@google.com>
Reviewed-by: Nooras Saba‎ <saba@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
@dle8 dle8 removed this from the Unreleased milestone Jun 21, 2022
@dle8 dle8 added this to the gopls/v0.9.0 milestone Jun 21, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2022

Change https://go.dev/cl/414497 mentions this issue: internal/lsp/debug: update hard-coded version for v0.9.0

gopherbot pushed a commit to golang/tools that referenced this issue Jun 27, 2022
We typically set the hard-coded version to the release version, even for
prereleases (else we can't tag a final release that is the same ref as
the prerelease).

For golang/go#53412

Change-Id: I57323d6a082e8fc410e4d0c8e8af7c61d13e65d9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/414497
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2022

Change https://go.dev/cl/414498 mentions this issue: gopls: update go.mod for v0.9.0-pre.2

gopherbot pushed a commit to golang/tools that referenced this issue Jun 27, 2022
Remove the replace directive and update x/tools.

For golang/go#53412

Change-Id: If14a031a9ed02bcce99fc0b4c9d7564babf8cb45
Reviewed-on: https://go-review.googlesource.com/c/tools/+/414498
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Tools
Projects
None yet
Development

No branches or pull requests

2 participants