Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: fix cmd/link/internal/ld.TestDictIndex for unified IR #54514

Closed
mdempsky opened this issue Aug 18, 2022 · 1 comment
Closed

cmd/compile: fix cmd/link/internal/ld.TestDictIndex for unified IR #54514

mdempsky opened this issue Aug 18, 2022 · 1 comment
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mdempsky
Copy link
Member

mdempsky commented Aug 18, 2022

Delve relies on ir.Name.DictIndex being set for local variables, so that their *runtime._type can be resolved dynamically.

cmd/link/internal/ld.TestDictIndex tests that this works, but it's currently disabled for unified IR.

@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 18, 2022
@mdempsky mdempsky added this to the Go1.20 milestone Aug 18, 2022
@mdempsky mdempsky self-assigned this Aug 18, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 18, 2022
@gopherbot
Copy link

gopherbot commented Aug 18, 2022

Change https://go.dev/cl/424735 mentions this issue: cmd/compile/internal/noder: set ir.Name.DictIndex for unified IR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants