go fmt traversing .git repository?

[gopherbot]

by chris@altonymous.com:

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Run go fmt on a directory that is a git clone.
2. It traverses the .git repository and throws errors

What is the expected output?
I expect it to ignore the hidden directories, aka .git

What do you see instead?
Instead I get errors about files that no longer exist because it's traversing the git
repository history files.

Which compiler are you using (5g, 6g, 8g, gccgo)?
std

Which operating system are you using?
OS X

Which version are you using?  (run 'go version')
1.1

Please provide any additional information below.
Didn't happen to me when I was running 1.0.3

[davecheney]

Comment 1:

Can you please include the output of go fmt trying to fmt your .git history (including
the command you ran) and a link to the repository you were using so others can try to
reproduce this problem.

Status changed to WaitingForReply.

[gopherbot]

Comment 2 by chris@altonymous.com:

.git/logs/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT'
0000000000000000000000000000000000000000
.git/logs/refs/remotes/origin/web.go:1:104: illegal character U+0040 '@'
.git/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT' 231759

[davecheney]

Comment 3:

Thank you for the update. I am unable to reproduce this on a few git based packages I am
working on. 
Can you please post the full output, including the command you ran, and possibly the
directory you ran it from.

[gopherbot]

Comment 4 by chris@altonymous.com:

the above is the full output.  Here is the command I am running.
gofmt --tabs=false --tabwidth=2 -l --w=true .

[robpike]

Comment 5:

I hate dot files.

[minux]

Comment 6:

what if the user actually defines a package in directory .git?

[gopherbot]

Comment 7 by chris@altonymous.com:

Why would anyone do that?

[minux]

Comment 8:

i don't know, but the language specification doesn't forbid that.

[gopherbot]

Comment 9 by chris@altonymous.com:

If go get us going to use git to manage the lib then it should adhere to git rules.  If
it is going to force me to mix my project with the GOPATH for building projects and I
choose to use git as my repository, it should respect that.  If it doesn't to these by
default the there should be a .goignore file or something g to tell it what I desire it
to exclude in my project directory.

[davecheney]

Comment 10:

OP, nobody has been able to reproduce the problem yet, so let's not jump to a solution.
In #4 you showed you were running gofmt in '.', but you didn't indicate what your
current working directory was. Were you running gofmt . inside the .git directory itself
?

[minux]

Comment 11:

the problem is running gofmt with "." as argument as it tells gofmt to scan the
current directory for packages (the correct usage is "go fmt ./...").
$ mkdir .git good
$ echo "bad syntax" > .git/bad.go
$ echo "package good" > good/good.go
$ gofmt .
.git/bad.go:1:1: expected 'package', found 'IDENT' bad
package good
$ go fmt ./...
$

[gopherbot]

Comment 12 by Saiba.Samurai:

I'm assuming you meant ../. because ./... is not a directory...
So I did this...
$ gofmt -l=true -w=true -tabs=false -tabwidth=2 ../.
.git/logs/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT'
0000000000000000000000000000000000000000
.git/logs/refs/remotes/origin/web.go:1:104: illegal character U+0040 '@'
.git/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT' 231759
Still errors.

[gopherbot]

Comment 13 by chris@altonymous.com:

I'm assuming you meant ../. because ./... is not a directory...
So I did this...
$ gofmt -l=true -w=true -tabs=false -tabwidth=2 ../.
.git/logs/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT'
0000000000000000000000000000000000000000
.git/logs/refs/remotes/origin/web.go:1:104: illegal character U+0040 '@'
.git/refs/remotes/origin/web.go:1:1: expected 'package', found 'INT' 231759
Still errors.

[gopherbot]

Comment 14 by chris@altonymous.com:

Aha!  I figured it out.  
I created a branch called web.go  That's what is causing the issue.  So if you create a
repo or branch with .go on the end it does the dirty deed.

[minux]

Comment 15:

no. it really is "./..." not "../.". this notation is go tool specific.

Status changed to Retracted.