New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: context that is scoped to http request lifecycle is passed to a goroutine #54927

Open

komuw opened this issue Sep 7, 2022 · 1 comment

Labels

pkgsite

Milestone

pkgsite/backlog

Contributor

komuw commented Sep 7, 2022

What did you do?

There's a context that is scoped to http request that has been passed to a gorutine
https://github.com/golang/pkgsite/blob/c2ebc4d393d3d50c7c0f39225304cbb44cb99d2c/internal/middleware/caching.go#L141-L160

What did you expect to see?

Use of pkgsite/internal/xcontext.Detach()
https://github.com/golang/pkgsite/blob/2d3ade3c90634f9afed7aa772e53a62bb433447a/internal/xcontext/xcontext.go#L14-L16

Hat tip to Damian Gryski who raised it up in gophers-slack

The text was updated successfully, but these errors were encountered:

gopherbot added the pkgsite label

gopherbot added this to the Unreleased milestone

Contributor Author

komuw commented Sep 7, 2022 •

edited

Loading

There's a related proposal; #40221

dle8 modified the milestones: Unreleased, pkgsite/later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment