Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: unhandled named anchor on the hover #57048

Closed
hyangah opened this issue Dec 2, 2022 · 2 comments
Closed

x/tools/gopls: unhandled named anchor on the hover #57048

hyangah opened this issue Dec 2, 2022 · 2 comments
Assignees
@pjweinb
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.11.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 2, 2022

Screen Shot 2022-12-02 at 9 12 32 AM

Either we need to drop or translate to a reasonable markdown element.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 2, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 2, 2022
@findleyr findleyr assigned findleyr and unassigned findleyr Dec 6, 2022
@dle8 dle8 modified the milestones: Unreleased, gopls/v0.11.0 Dec 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/456535 mentions this issue: gopls/hover: remove header tags from hover markdown

@gopherbot
Copy link

Change https://go.dev/cl/456641 mentions this issue: gopls/hover: remove header tags from hover markdown

gopherbot pushed a commit to golang/tools that referenced this issue Dec 9, 2022
@pjweinbgo @hyangah
[gopls-release-branch.0.11] gopls/hover: remove header tags from hove…
082fc58 
…r markdown

Lines in go doc that look like '// ## Header' generate, by
default, tags in the markdown that look like '{hdr-Header}'
which are harmless and annoying. This CL generates the markdown
without the tags.

Fixes: golang/go#57048
Change-Id: I7109775ea3ec6b51504d62108187e3614b2d1e9d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456535
Run-TryBot: Peter Weinberger <pjw@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456641
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjweinb pjweinb

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.11.0
Development

No branches or pull requests
5 participants
@hyangah @pjweinb @gopherbot @dle8 @findleyr