Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: allow renaming arbitrary package paths #57171

Open
3 tasks
findleyr opened this issue Dec 8, 2022 · 0 comments
Open
3 tasks

x/tools/gopls: allow renaming arbitrary package paths #57171

findleyr opened this issue Dec 8, 2022 · 0 comments
Assignees
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Dec 8, 2022

This issue proposes to extend gopls' package renaming feature to prompt with the full package path of the the package (rather than just the package name), and allow arbitrary edits of the package path, potentially even across module boundaries.

(aside: this feature was originally part of #56184, but is significant enough in scope to warrant its own issue).

Specifically, we should:

  • Prompt with the full package path in preparerename requests.
  • Validate whether an arbitrary package path move can be allowed.
  • Compute the (potentially complicated) set of workspace edits to implement the package move.

The pieces of this exists in the current renaming code, but must be generalized.

@findleyr findleyr added this to the gopls/later milestone Dec 8, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants