Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: document that GenerateKey functions are not deterministic #58637

Open
FiloSottile opened this issue Feb 22, 2023 · 0 comments
Open

crypto: document that GenerateKey functions are not deterministic #58637

FiloSottile opened this issue Feb 22, 2023 · 0 comments
Assignees
@FiloSottile
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@FiloSottile
Copy link
Contributor

In Go 1.20 we finally made crypto/ecdsa.GenerateKey call MaybeReadByte, so that now all GenerateKey implementation are non-deterministic, avoiding applications relying on the internals of our implementation, which would stop us from ever changing them. We should document this.
@FiloSottile FiloSottile added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Feb 22, 2023
@FiloSottile FiloSottile added this to the Go1.21 milestone Feb 22, 2023
@FiloSottile FiloSottile self-assigned this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FiloSottile FiloSottile

Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
1 participant
@FiloSottile