Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: automatically bump RLIMIT_NOFILE on Unix [1.20 backport] #59064

Open
gopherbot opened this issue Mar 15, 2023 · 2 comments
Open

runtime: automatically bump RLIMIT_NOFILE on Unix [1.20 backport] #59064

gopherbot opened this issue Mar 15, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.20.3

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #46279 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport issues.

CL 393354, which first appeared in Go one point nineteen, causes Go programs that start other non-Go programs to lose the soft NOFILES rlimit. This breaks programs that care about that. CLs 476096 and 476097 fix the problem by changing the syscall fork and exec functions to restore the original soft rlimit if appropriate. This is a request to backport those changes to the currently supported releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 15, 2023
@gopherbot gopherbot mentioned this issue Mar 15, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 15, 2023
@gopherbot gopherbot added this to the Go1.20.3 milestone Mar 15, 2023
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Mar 22, 2023
@heschi
Copy link
Contributor

heschi commented Mar 22, 2023

Fix CL seems largeish but harmless; as long as the backport CLs aren't more complicated, approved.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 22, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/478659 mentions this issue: [release-branch.go1.20] syscall: restore original NOFILE rlimit in child process

@thaJeztah thaJeztah mentioned this issue Mar 28, 2023
Open
paralin added a commit to skiffos/buildroot that referenced this issue Mar 29, 2023
@paralin
package/go: backport fix for rlimit nofile regression
f26ad9d 
golang/go#59064
https://go-review.googlesource.com/c/go/+/478659

Signed-off-by: Christian Stewart <christian@paral.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
Go Compiler / Runtime
Status: No status
Milestone
Go1.20.3
Development

No branches or pull requests
2 participants
@gopherbot @heschi