x/tools/gopls: strange unified diff

[adonovan]

The unified diff output gopls format includes a \ No newline at end of file line in the middle of the file. Is that valid?

xtools$ git log | head -n 1
commit 7a03febeeead7497d3821eb99461ecfeae51c0ba

xtools$ cat a/a.go 
package a

type S struct {
s fmt.Stringer
}
xtools$ go run ./gopls format -d ./a/a.go
--- /Users/adonovan/w/xtools/a/a.go.orig
+++ /Users/adonovan/w/xtools/a/a.go
@@ -1,5 +1,6 @@
 package a
 
 type S struct {
+	
\ No newline at end of file
 s fmt.Stringer
 }

xtools$ go run ./gopls format -w ./a/a.go

xtools$ cat ./a/a.go 
package a

type S struct {
	s fmt.Stringer
}

[pjweinb]

Yes, the code wrongly concludes that an insertion at the beginning of a line replaces the whole line. There's already a TODO in the code, so some clear thought is required.

…

On Tue, May 23, 2023 at 10:54 PM Alan Donovan ***@***.***> wrote: Assigned #60379 <#60379> to @pjweinb <https://github.com/pjweinb>. — Reply to this email directly, view it on GitHub <#60379 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIAIZMATXQU2GNRUXPKUDXHVZ57ANCNFSM6AAAAAAYMW5WMM> . You are receiving this because you were assigned.Message ID: ***@***.***>

[gopherbot]

Change https://go.dev/cl/498975 mentions this issue: internal/diff: fix lineEdits

[gopherbot]

Change https://go.dev/cl/499377 mentions this issue: internal/diff: fix LineEdits bug in slow path

[gopherbot]

Change https://go.dev/cl/499376 mentions this issue: internal/diff: fix LineEdits bug in fast path