cmd/compile/internal/types2: TestIssue43124 fails randomly in go1.21rc2 #61064
Comments
gopherbot
added
the
compiler/runtime
|
Curiously, It looks like the (attn @griesemer, @findleyr) |
cagedmantis
added
the
NeedsInvestigation
|
Change https://go.dev/cl/507215 mentions this issue: |
…ersion
Replace the (flaky) types2.TestIssue43124 with the code of the
(stable) go/types version of this test.
While at it, replace a handful of syntax.Pos{} with the equivalent
nopos, to further reduce differences between the two versions of
the issues_test.go file.
For #61064.
Change-Id: I69f3e4627a48c9928e335d67736cb875ba3835fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/507215
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
|
@zhsj, is it possible that your VM has too low of a memory limit? I can get a similar failure mode by killing the That command may be fairly expensive if it ends up needing to build |
bcmills
added
the
WaitingForInfo
|
It's in docker at my workstation. Host has 32G memory. I didn't notice OOM kill event when building. |
|
Change https://go.dev/cl/507360 mentions this issue: |
…ersion
Replace the (flaky) types2.TestIssue43124 with the code of the
(stable) go/types version of this test.
While at it, replace a handful of syntax.Pos{} with the equivalent
nopos, to further reduce differences between the two versions of
the issues_test.go file.
For golang#61064.
Change-Id: I69f3e4627a48c9928e335d67736cb875ba3835fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/507215
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
|
Change https://go.dev/cl/511758 mentions this issue: |
…n other repos TestImportedTypes was assuming that go/internal/gcimporter declares a FindPkg function with a particular signature. However, since go/internal/gcimporter is internal, it is not subject to Go 1 compatibility and its API is subject to change. I intend to change it in CL 507360. For golang/go#61064. Change-Id: I994f5b967ce9c57d07ce1fe8b6ce900176848efa Reviewed-on: https://go-review.googlesource.com/c/tools/+/511758 Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Bryan Mills <bcmills@google.com>
Previously, FindPkg returned the empty string as a sentinel value, causing Import to collapse all errors to "can't find import". (See also https://go.dev/wiki/CodeReviewComments#in-band-errors.) For #61064. Change-Id: I21f335d206308b44fe585619e00782abb0b65a94 Reviewed-on: https://go-review.googlesource.com/c/go/+/507360 Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com>
seankhliao
removed
the
WaitingForInfo
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
Build go1.21rc2
bash run.bash -k -no-rebuildWhat did you expect to see?
No error
What did you see instead?
No sure what happens. I build it in clean docker env. And it doesn't always fail...
The text was updated successfully, but these errors were encountered: