cmd/vet: incorrect "redundant invocation" report

[fsouza]

% cat abc.go
package main

import (
    "fmt"
)

type Person struct {
    name string
}

func (p *Person) String() string {
    return p.name
}

func main() {
    p := Person{name: "Gopher"}
    fmt.Printf("%s\n", p.String())
}
% go vet abc.go
abc.go:17: redundant invocation of String method of p

It's not redundant, because String method requires a pointer receiver. So, *Person
implements the Stringer interface, but Person does not.

Following vet advice produces the wrong result: http://play.golang.org/p/CnXisy9MC_.

[robpike]

Comment 1:

I vote for just reverting the CL that added this. It's not a problem to be explicit
about those methods even when they are unnecessary.

Labels changed: added priority-soon, removed priority-triage, go1.2maybe.

Owner changed to @dsymonds.

Status changed to Accepted.

[dsymonds]

Comment 2:

Yeah, I have also tripped over this. It could use the typechecker a little more to work
out whether p has the method on that type, but maybe this is just overstepping govet's
purview.
Give me a day to think about it.

[dsymonds]

Comment 3:

This issue was closed by revision golang/tools@a7c698b.

Status changed to Fixed.