-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls/internal/regtest/diagnostics: TestOrphanedFiles failures #61521
Comments
Found new dashboard test flakes for:
2023-07-20 20:41 darwin-amd64-11_0 tools@3e82a5b1 go@e201ff2b x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-07-24 17:08 darwin-amd64-11_0 tools@67ba5997 go@bd3a1f24 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
It seems like there be a nondeterministic log ordering problem here: the sequence of events is:
The first publishDiagnostics event causes the test to read the logs and count 5 "Load" events, then the sixth shows up late, but still before the didChange. Then the second publishDiagnostics causes the test to read the log again and count 6. Are the publishDiagnostics events asynchronous to the Load logMessage events? |
@adonovan I think we discovered only very recently that log messages in general are not synchronous. I forgot. I wonder if fixing that would fix this test? If that's it, funny that it bit us so soon after we recognized the long-standing bug. |
Change https://go.dev/cl/513097 mentions this issue: |
Indeed. I spent 10 minutes today looking for the statement of the form |
Found new dashboard test flakes for:
2023-07-26 13:22 netbsd-386-9_3 tools@e8cdaf46 go@af297c35 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Whelp, this one was not just async logging, apparently! Will take a look. |
Found new dashboard test flakes for:
2023-07-26 13:22 freebsd-amd64-12_3 tools@e8cdaf46 go@bd3a1f24 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-07-27 16:59 linux-amd64-fedora tools@bacac149 go@10d85fa0 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-07-28 18:16 dragonfly-amd64-622 tools@82861e03 go@9c62ef12 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-07-28 18:16 darwin-arm64-12 tools@82861e03 go@2ad666de x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-07-28 18:16 freebsd-riscv64-unmatched tools@82861e03 go@d8c75273 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-01 16:52 darwin-amd64-longtest tools@5b4d4266 go@b6898dde x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-01 21:56 darwin-amd64-longtest tools@75f6f9c0 go@2350afd2 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-02 17:46 darwin-amd64-nocgo tools@e0783a89 go@499a1200 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-02 17:46 dragonfly-amd64-622 tools@e0783a89 go@9ff01162 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-07 00:27 darwin-amd64-11_0 tools@f91c023a go@adb775e3 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
2023-08-07 00:27 darwin-amd64-nocgo tools@f91c023a go@0ae54ddd x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-07 12:58 darwin-amd64-12_0 tools@2dc7ebab go@adb775e3 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-07 13:23 aix-ppc64 tools@229f8486 go@4e728e51 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Found new dashboard test flakes for:
2023-08-07 19:27 dragonfly-amd64-622 tools@f42bca8e go@aca65771 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Change https://go.dev/cl/518975 mentions this issue: |
Found new dashboard test flakes for:
2023-08-09 20:39 darwin-amd64-12_0 tools@053d3c44 go@d9f7e1dc x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
2023-08-09 20:39 linux-386-bullseye tools@053d3c44 go@ada5f8a4 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
2023-08-10 21:06 darwin-amd64-11_0 tools@6b4d1de1 go@f47cfd6c x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
2023-08-10 21:06 darwin-amd64-longtest tools@6b4d1de1 go@33cdafed x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
2023-08-10 21:06 linux-ppc64le-buildlet tools@6b4d1de1 go@8870b8d2 x/tools/gopls/internal/regtest/diagnostics.TestOrphanedFiles (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: