Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys: v0.14.0 removes definition of BPF_F_KPROBE_MULTI_RETURN in unix/zerrors_linux.go #63969

Closed
brycekahle opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@brycekahle
Copy link

What version of Go are you using (go version)?

go version go1.20.10 linux/arm64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="arm64"
GOBIN=""
GOCACHE="/home/vagrant/.cache/go-build"
GOENV="/home/vagrant/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/vagrant/go/pkg/mod"
GONOPROXY="github.com/DataDog"
GONOSUMDB="github.com/DataDog"
GOOS="linux"
GOPATH="/home/vagrant/go"
GOPRIVATE="github.com/DataDog"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/vagrant/.gimme/versions/go1.20.10.linux.arm64"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/vagrant/.gimme/versions/go1.20.10.linux.arm64/pkg/tool/linux_arm64"
GOVCS=""
GOVERSION="go1.20.10"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
GOWORK=""
CGO_CFLAGS="-I/git/datadog-agent/dev/include"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-L/git/datadog-agent/dev/lib"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1187157903=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Updated golang.org/x/sys dependency to v0.14.0

What did you expect to see?

Continued definition of BPF_F_KPROBE_MULTI_RETURN

What did you see instead?

Error: /home/runner/go/pkg/mod/github.com/cilium/ebpf@v0.12.2/internal/unix/types_linux.go:41:36: undefined: linux.BPF_F_KPROBE_MULTI_RETURN

This commit removed the definition. This is likely because it was changed from a #define to an enum in torvalds/linux@c5487f8

@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2023
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Nov 6, 2023

(attn @tklauser)

@tklauser tklauser self-assigned this Nov 6, 2023
@tklauser tklauser added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 6, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/540395 mentions this issue: unix: update BPF constants for Linux kernel 6.6

DmitriyMV added a commit to DmitriyMV/siderolink that referenced this issue Nov 7, 2023
Wait for golang/go#63969 to resolve.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
tklauser added a commit to cilium/cilium that referenced this issue Nov 9, 2023
Updating golang.org/x/sys/unix to the recently releases v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to unblock #28994 and allow renovate to update other
dependencies.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to cilium/cilium that referenced this issue Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to unblock #28994 and allow renovate to update other
dependencies.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to tklauser/ebpf that referenced this issue Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969 and
cilium#1206.

This was fixed upstream in https://go.dev/cl/540395, so manually pull in
the latest unreleased version to allow modules depending on cilium/ebpf
to update to later versions as well.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
lmb pushed a commit to cilium/ebpf that referenced this issue Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969 and
#1206.

This was fixed upstream in https://go.dev/cl/540395, so manually pull in
the latest unreleased version to allow modules depending on cilium/ebpf
to update to later versions as well.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to cilium/cilium that referenced this issue Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to unblock #28994 and allow renovate to update other
dependencies.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
rolinh added a commit to cilium/hubble that referenced this issue Nov 15, 2023
Updating `golang.org/x/sys/unix` to the recently released v0.14.0 breaks
the build because of the missing definition of
`BPF_F_KPROBE_MULTI_RETURN`, see golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to allow renovate to update other dependencies.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh added a commit to cilium/hubble that referenced this issue Nov 15, 2023
Updating `golang.org/x/sys/unix` to the recently released v0.14.0 breaks
the build because of the missing definition of
`BPF_F_KPROBE_MULTI_RETURN`, see golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to allow renovate to update other dependencies.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
sujoshua pushed a commit to sujoshua/cilium that referenced this issue Nov 16, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to unblock cilium#28994 and allow renovate to update other
dependencies.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
nicoche added a commit to koyeb/kuma that referenced this issue Nov 21, 2023
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this issue Dec 15, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will
break the build because of the missing definition of
BPF_F_KPROBE_MULTI_RETURN, see
golang/go#63969.

This was fixed upstream, so manually pull in the latest unreleased
version to unblock cilium#28994 and allow renovate to update other
dependencies.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@golang golang locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants