Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: on timeout, running tests: message includes non-running parent tests #64404

Closed
bcmills opened this issue Nov 27, 2023 · 2 comments
Closed
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 27, 2023

Go version

commit d1dcffd

What operating system and processor architecture are you using (go env)?

wasip1-wasm-wazero at d1dcffdb4a40f8ea89d9e57744142f9805b64840

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash"] and env ["HOSTNAME=buildlet-linux-amd64-wasip1-wasm-wazero-rnb6e0d3c" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=wasip1-wasm-wazero" "GOOS=wasip1" "GOARCH=wasm" "GOHOSTOS=linux" "GOHOSTARCH=amd64" "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/workdir/go/misc/wasm" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOWASIRUNTIME=wazero" "GOBIN=" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache" "GOPLSCACHE=/workdir/goplscache" "PWD=/workdir/go/src"] in dir /workdir/go/src

…

##### Test execution environment.
# GOARCH: wasm
# CPU: 
# GOOS: wasip1
# OS Version: UNKNOWN: error determining OS version: unable to determine OS version: unsupported operation


### What did you do?

https://build.golang.org/log/c8fc86fc4fd4a47a9f825128843b56e2e61db057

### What did you expect to see?

A `running tests` message that indicates the specific tests that are actually running a test or cleanup function, but does not include tests that are blocked in `testing.T.Parallel`, and _also_ does not include parent tests that are blocked on waiting for their own child subtests to complete.

In this case, something like:

panic: test timed out after 3m0s
running tests:
TestTransportExpect100Continue/h1 (2s)


### What did you see instead?

panic: test timed out after 3m0s
running tests:
TestClientRedirectNoLocation (2m49s)
TestClientRedirectNoLocation/h1 (2m20s)
TestClientRedirectNoLocation/h2 (2m20s)
TestConnContextNotModifyingAllContexts (2m48s)
TestContentEncodingNoSniffing (2m48s)
TestContentTypeWithVariousSources (2m48s)
TestDisableContentLength (2m48s)
TestDisableKeepAliveUpgrade (2m48s)
TestGetBody (2m48s)
TestHandlerSetsBodyNil (2m48s)
TestHeadBody (2m48s)
TestNoContentLengthIfTransferEncoding (2m48s)
TestParseFormCleanup (2m48s)
TestQuerySemicolon (2m48s)
TestRequestBodyCloseDoesntBlock (2m48s)
TestReuseRequest (2m48s)
TestRoundTripGzip (2m48s)
TestSOCKS5Proxy (2m48s)
TestServerCancelsReadHeaderTimeoutWhenIdle (2m48s)
TestServerCancelsReadTimeoutWhenIdle (2m48s)
TestServerConnState (2m48s)
TestServerContentTypeSniff (2m48s)
TestServerContext_LocalAddrContextKey (2m48s)
TestServerContext_ServerContextKey (2m48s)
TestServerContexts (2m48s)
TestServerDuplicateBackgroundRead (2m48s)
TestServerEmptyBodyRace (2m48s)
TestServerFlushAndHijack (2m48s)
TestServerHandlersCanHandleH2PRI (2m48s)
TestServerHijackGetsBackgroundByte (2m48s)
TestServerHijackGetsBackgroundByte_big (2m48s)
TestServerIdleTimeout (2m48s)
TestServerIssue5953 (2m48s)
TestServerKeepAliveAfterWriteError (2m48s)
TestServerKeepAlivesEnabledResultClose (2m48s)
TestServerRequestContextCancel_ConnClose (2m48s)
TestServerRequestContextCancel_ServeHTTPDone (2m48s)
TestServerSetKeepAlivesEnabledClosesConns (2m48s)
TestServerShutdown (2m48s)
TestServerShutdownStateNew (2m48s)
TestSniffWriteSize (2m48s)
TestStressSurpriseServerCloses (2m48s)
TestTimeoutHandlerSuperfluousLogs (2m48s)
TestTransportConnectionCloseOnRequest (2m48s)
TestTransportConnectionCloseOnRequestDisableKeepAlive (2m48s)
TestTransportConnectionCloseOnResponse (2m48s)
TestTransportExpect100Continue (2m48s)
TestTransportExpect100Continue/h1 (2s)
TestTransportGzip (2m48s)
TestTransportHeadResponses (2m48s)
TestTransportIdleCacheKeys (2m48s)
TestTransportKeepAlives (2m48s)
TestTransportMaxConnsPerHost (2m48s)
TestTransportMaxConnsPerHostIncludeDialInProgress (2m48s)
TestTransportMaxPerHostIdleConns (2m48s)
TestTransportReadToEndReusesConn (2m48s)
TestTransportRemovesDeadIdleConnections (2m48s)
TestTransportRespectRequestWantsClose (2m48s)
TestTransportServerClosingUnexpectedly (2m48s)
TestUnsupportedTransferEncodingsReturn501 (2m48s)
TestWriteHeaderSwitchingProtocols (2m48s)

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 27, 2023
@bcmills bcmills self-assigned this Nov 27, 2023
@bcmills bcmills added this to the Backlog milestone Nov 27, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Nov 27, 2023

I think this was incidentally fixed in https://go.dev/cl/506755, but reverted in https://go.dev/cl/544895 due to other regressions.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/546018 mentions this issue: testing: remove tests from the running log while they are waiting on parallel subtests

@golang golang locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants