net/http/httputil: DumpRequestOut(req, false) fails if req.Body != nil

[gopherbot]

by sdefresne:

The httputil.DumpRequestOut second parameter control whether it should dump the request
body or not. However, if the request contains a body, and second parameter is false,
then the function fails with error: "http: Request.ContentLength=%d with nil
Body".

This can be checked here:
http://play.golang.org/p/UiU6kwcEox

I guess this is because the implementation does use a real Transport to send the request
to a fake server and record it.

[rsc]

Comment 1:

Okay to fix if it's trivial.

Labels changed: added priority-later, go1.2maybe, removed priority-triage.

Status changed to Accepted.

[bradfitz]

Comment 2:

Sure... https://golang.org/cl/14920050

Owner changed to @bradfitz.

Status changed to Started.

[bradfitz]

Comment 3:

This issue was closed by revision 1428045.

Status changed to Fixed.

[adg]

Comment 4:

This issue was closed by revision 01bdd721c137.