x/tools/gopls/internal/cmd: TestFix failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

Issue created automatically to collect these failures.

Example (log):

2023/12/15 22:30:48 New session
	create_session=1
Log: Loading packages...
2023/12/15 22:30:48 go info for /workdir/tmp/fake4193955195
(go dir /workdir/tmp/fake4193955195)
(go version go version go1.21.5 linux/ppc64le)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/workdir/gocache, GOFLAGS=, GOMODCACHE=/workdir/gopath/pkg/mod, GOPATH=/workdir/gopath, GOPRIVATE=, GOROOT=/workdir/go, GOWORK=])

...
--- FAIL: TestFix (1.14s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2023-12-15 21:59 linux-ppc64le-buildlet tools@4d2b6e1d go@bbab863a x/tools/gopls/internal/cmd.TestFix (log)

2023/12/15 22:30:48 New session
	create_session=1
Log: Loading packages...
2023/12/15 22:30:48 go info for /workdir/tmp/fake4193955195
(go dir /workdir/tmp/fake4193955195)
(go version go version go1.21.5 linux/ppc64le)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/workdir/gocache, GOFLAGS=, GOMODCACHE=/workdir/gopath/pkg/mod, GOPATH=/workdir/gopath, GOPRIVATE=, GOROOT=/workdir/go, GOWORK=])

...
--- FAIL: TestFix (1.14s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes

[findleyr]

May be related to my change to diagnostic logic. Let's see.

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2023-12-18 20:56 linux-ppc64-sid-power10 tools@ee47fd47 go@52dbffea x/tools/gopls/internal/cmd.TestFix (log)

2023/12/19 14:57:06 New session
	create_session=1
Log: Loading packages...
2023/12/19 14:57:06 go info for /workdir/tmp/fake2287754878
(go dir /workdir/tmp/fake2287754878)
(go version go version devel 52dbffeac86863e1e0c9455b5b216ec50c828946 linux/ppc64)
(valid build configuration = true)
(build flags: [])

2023/12/19 14:57:06 go/packages.Load #1
...
--- FAIL: TestFix (1.13s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2023-12-19 22:22 netbsd-arm64-bsiegert tools@160631f7 go@8cb86b5f x/tools/gopls/internal/cmd.TestFix (log)

2023/12/20 00:09:05 New session
	create_session=1
Log: Loading packages...
2023/12/20 00:09:05 go info for /var/gobuilder/buildlet/tmp/fake534038479
(go dir /var/gobuilder/buildlet/tmp/fake534038479)
(go version go version go1.20.12 netbsd/arm64)
(valid build configuration = true)
(build flags: [])

2023/12/20 00:09:05 go/packages.Load #1
...
--- FAIL: TestFix (6.52s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2023-12-26 17:53 freebsd-arm64-dmgk tools@025ebe62 go@bbab863a x/tools/gopls/internal/cmd.TestFix (log)

2023/12/26 18:48:59 New session
	create_session=1
Log: Loading packages...
2023/12/26 18:48:59 go info for /tmp/workdir-host-freebsd-arm64-dmgk/tmp/fake2191482282
(go dir /tmp/workdir-host-freebsd-arm64-dmgk/tmp/fake2191482282)
(go version go version go1.21.5 freebsd/arm64)
(valid build configuration = true)
(build flags: [])

2023/12/26 18:48:59 go/packages.Load #1
...
--- FAIL: TestFix (2.27s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2023-12-31 00:29 windows-amd64-race tools@baf6fd25 go@b25f5558 x/tools/gopls/internal/cmd.TestFix (log)

2023/12/31 00:37:06 New session
	create_session=1
Log: Loading packages...
2023/12/31 00:37:06 go info for C:\Users\gopher\AppData\Local\Temp\1\fake2524320266
(go dir C:\Users\gopher\AppData\Local\Temp\1\fake2524320266)
(go version go version devel b25f5558c69140deb652337afaab5c1186cd0ff1 windows/amd64)
(valid build configuration = true)
(build flags: [])

2023/12/31 00:37:06 go/packages.Load #1
...
--- FAIL: TestFix (18.20s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed
2023/12/31 00:37:36 background imports cache refresh starting
2023/12/31 00:37:37 background refresh finished after 375.0014ms

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestFix"

2024-01-03 10:09 linux-arm-aws tools@5e6f314f go@8cb86b5f x/tools/gopls/internal/cmd.TestFix (log)

2024/01/03 10:19:18 New session
	create_session=1
Log: Loading packages...
2024/01/03 10:19:18 go info for /workdir/tmp/fake1663239641
(go dir /workdir/tmp/fake1663239641)
(go version go version go1.20.12 linux/arm)
(valid build configuration = true)
(build flags: [])

2024/01/03 10:19:18 go/packages.Load #1
...
--- FAIL: TestFix (1.38s)
    integration_test.go:963: fix: got <<>>, want <<package a
        type T int
        func f() (int, string) { return 0, "" }

        >>
        stderr:
        Log: Loading packages...
        Info: Finished loading packages.
        Log: Running...
        Info: completed

— watchflakes