x/tools/gopls/internal/test/integration/workspace: TestMultiView_Diagnostics/default failures

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestMultiView_Diagnostics/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestMultiView_Diagnostics/default
    multi_folder_test.go:47: unmeetable expectations:
        Unmeetable: once "completed work \"diagnosing initial workspace load\" 1 times" is met, must have:
        any diagnostics at the first position (3:1) matching `x` in "a/a.go"
        any diagnostics at the first position (3:1) matching `y` in "b/b.go"
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/01/19 05:56:43 go info for /Users/swarming/.s...
        	Info: "2024/01/19 05:56:43 go/packages.Load #52\n\tsnapsh...
...
[Trace - 05:56:43.826 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-1796089135/TestMultiView_Diagnostics/default/work/b/b.go","diagnostics":[]}


[Trace - 05:56:43.826 AM] Received notification '$/progress'.
Params: {"token":"4350567714093047342","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestMultiView_Diagnostics/default"
--- FAIL: TestMultiView_Diagnostics/default (0.24s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestMultiView_Diagnostics/default"

2024-01-19 13:52 x_tools-gotip-darwin-amd64_12 tools@6673e7a4 go@66d34c7d x/tools/gopls/internal/test/integration/workspace.TestMultiView_Diagnostics/default (log)

=== RUN   TestMultiView_Diagnostics/default
    multi_folder_test.go:47: unmeetable expectations:
        Unmeetable: once "completed work \"diagnosing initial workspace load\" 1 times" is met, must have:
        any diagnostics at the first position (3:1) matching `x` in "a/a.go"
        any diagnostics at the first position (3:1) matching `y` in "b/b.go"
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/01/19 05:56:43 go info for /Users/swarming/.s...
        	Info: "2024/01/19 05:56:43 go/packages.Load #52\n\tsnapsh...
...
[Trace - 05:56:43.826 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-1796089135/TestMultiView_Diagnostics/default/work/b/b.go","diagnostics":[]}


[Trace - 05:56:43.826 AM] Received notification '$/progress'.
Params: {"token":"4350567714093047342","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestMultiView_Diagnostics/default"
--- FAIL: TestMultiView_Diagnostics/default (0.24s)

— watchflakes

[bcmills]

Note that TestMultiView_Diagnostics/default ran for less than a quarter of a second. This looks like another symptom of #65040.

[findleyr]

No, this looks like a potentially real bug in gopls diagnostics. Investigating...

[gopherbot]

Change https://go.dev/cl/563957 mentions this issue: gopls/internal/server: fix a (mostly) benign race in diagnostics