Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/misc: TestRunGovulncheckStd/default failures #65463

Closed
gopherbot opened this issue Feb 2, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunGovulncheckStd/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestRunGovulncheckStd/default
    vuln_test.go:212: waiting on:
        Unmeetable: once "completed work for token 305887691981291656" is met, must have:
        received window/showMessage containing "Found GOSTDLIB"
        no diagnostics for file "go.mod"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
...
[Trace - 08:10:53.060 AM] Received notification 'window/showMessage'.
Params: {"type":1,"message":"failed to read govulncheck output: failed to run govulncheck: exit status 1"}


[Trace - 08:10:53.060 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2024/02/02 08:10:53 command error: failed to read govulncheck output: failed to run govulncheck: exit status 1\n"}


#### End Gopls Test Logs for "TestRunGovulncheckStd/default"
--- FAIL: TestRunGovulncheckStd/default (1.52s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunGovulncheckStd/default"
2024-02-02 15:44 x_tools-gotip-darwin-amd64_13 tools@e211e0f0 go@149db960 x/tools/gopls/internal/test/integration/misc.TestRunGovulncheckStd/default (log)
=== RUN   TestRunGovulncheckStd/default
    vuln_test.go:212: waiting on:
        Unmeetable: once "completed work for token 305887691981291656" is met, must have:
        received window/showMessage containing "Found GOSTDLIB"
        no diagnostics for file "go.mod"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
...
[Trace - 08:10:53.060 AM] Received notification 'window/showMessage'.
Params: {"type":1,"message":"failed to read govulncheck output: failed to run govulncheck: exit status 1"}


[Trace - 08:10:53.060 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2024/02/02 08:10:53 command error: failed to read govulncheck output: failed to run govulncheck: exit status 1\n"}


#### End Gopls Test Logs for "TestRunGovulncheckStd/default"
--- FAIL: TestRunGovulncheckStd/default (1.52s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 2, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2024
@findleyr
Copy link
Contributor

findleyr commented Feb 6, 2024

CC @hyangah. Digging into the govulncheck log message, I see "device error".

Looks like a builder issue. Closing optimistically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants