Skip to content

proposal: os/signal: enhance NotifyContext() to return a context with cancel cause #66032

@27149chen

Description

@27149chen

Proposal Details

Currently, NotifyContext returns a context without cancel cause

func NotifyContext(parent context.Context, signals ...os.Signal) (ctx context.Context, stop context.CancelFunc) {
    ctx, cancel := context.WithCancel(parent)
    ...
}

It is better to return a cause so that we can know it is canceled by a signal
Like that:

func NotifyContext(parent context.Context, signals ...os.Signal) (ctx context.Context, stop context.CancelFunc) {
    ctx, cancel := context.WithCancelCause(parent)
    ...
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions