go.tools/pointer: TestInput fails on windows

[alexbrainman]

What steps will reproduce the problem?

go test -run=Input code.google.com/p/go.tools/pointer

What is the expected output?

PASS

What do you see instead?

Entering directory `c:\go\path\others\src\code.google.com\p\go.tools\pointer'
testdata/hello.go:20: value may additionally alias these labels:
makeslice@c:\go\root\src\pkg\os\exec_windows.go:98:13
======== NEW ANALYSIS ========
    create n0 invalid type for (zero)
    create n1 interface{} for panic
    create n2 func() int for (*reflect.rtype).Align
    ---- makeFunctionObject (*reflect.rtype).Align
    create n3 func() int for func.cgnode
    create n4 *reflect.rtype for func.recv
    create n5 int for func.results#0
    ----
... (megabytes of output removed here)
pts(n36185) = {n36183} : uintptr
pts(n36188) = {n36186} : *errors.errorString
pts(n36191) = {n36189} : *syscall.DLLError
pts(n36194) = {n36192} : reflect.Value
pts(n36197) = {n36195} : syscall.Errno
pts(n36200) = {n21892} : error
pts(n36234) = {n36232} : int32
pts(n36237) = {n36235} : *main.S
pts(n36240) = {n3558} : error
pts(n36285) = {n36283} : errors.errorString
pts(n36288) = {n36286} : main.S
pts(n36291) = {n36289} : syscall.DLLError
pts(n36294) = {n21892} : error
pts(n36304) = {n3558} : error
    call edge synthetic function call -> cg182:main.main
    call edge synthetic function call -> cg180:main.init
    call edge dynamic method call -> cg1847:(*os.fileStat).Name
    call edge dynamic function call -> cg11509:fmt.notSpace
    call edge dynamic function call -> cg7510:time.initLocal
    call edge dynamic method call -> cg2727:(*syscall.DLLError).Error
    call edge dynamic method call -> cg2715:(syscall.Errno).Error
    call edge dynamic method call -> cg1424:(*errors.errorString).Error
    call edge dynamic method call -> cg1917:(*main.S).String
    call edge dynamic method call -> cg1326:(*os.File).Write
    call edge dynamic function call -> cg17338:func@19.20
    call edge static function call -> cg1410:(*os.file).close
    call edge dynamic function call -> cg17191:func@161.23
--- FAIL: TestInput (8.53 seconds)
FAIL
FAIL    code.google.com/p/go.tools/pointer  9.844s

Please use labels and text to provide additional information.

hg id is "75b3759eb0fd tip".

Alex

[alexbrainman]

Comment 1:

adonovan,
testdata/hello.go:20 assumes that
os.Args @pointsto <command-line args>
and nothing else, but on window os.Args is set at
c:\go\root\src\pkg\os\exec_windows.go:98:13. I suspect the assumption is wrong and needs
to be changed.
How should I fix this?
Alex

[adonovan]

Comment 2:

Thanks for the report.   I've mailed you CL https://golang.org/cl/17820044 to
fix this particular test, but I have no way to test it, plesdr so let me know if it
works for you.
The CL should fix this particular instance but in general the there may be differences
between the points-to relations on different platforms because they execute different
code.  Such differences are hopefully minor but they do need to be addressed; it's on my
TODO list.

[alexbrainman]

Comment 3:

> ... mailed you CL https://golang.org/cl/17820044 ...
Test PASSes now here. And builders are happy too, thank you very much. I just wanted to
have builders green, because there might be other broken things. And now we know -
everything is good.
I take it, you want to keep this issue opened?
Alex

[adonovan]

Comment 4:

Status changed to Fixed.